Commit graph

3681 commits

Author SHA1 Message Date
Julian Stirling
ba84dc2f92 Be clear that quadratic can be used with a float or an array 2025-10-24 17:34:32 +01:00
Julian Stirling
08046ff657 Clarify behaviour of overloads, and better error checking of _move_and_measure inputs 2025-10-24 17:27:43 +01:00
Julian Stirling
ba8a4ca744 Apply suggestions from code review of branch rom_test_only
Co-authored-by: Beth Probert <beth_probert@outlook.com>
2025-10-24 14:05:07 +00:00
Julian Stirling
82f435256b Release lock at end of ROM test 2025-10-22 09:57:01 +01:00
Julian Stirling
b8eb1907c3 Modify range of motion _move_back_until_motion_detected to move in SMALL_STEP steps
This will carry on until at least 1.5x BIG_STEP in total motion. If
no motion is detected then something is up.
2025-10-21 14:40:18 +01:00
Julian Stirling
bffd7f9d0b Improve type consistency and error message 2025-10-21 10:48:53 +01:00
Julian Stirling
7f657ae853 No error on parasitic motion after small step checking for stage movement, use background detect 2025-10-20 23:02:08 +01:00
Julian Stirling
72c35c302c Adjust CSM Thing to allow calculation of stage coords from img coords and use this in stage measure
Using this stops the z-axis being flipped when the off diagonal elements of the CSM are different
signs.
2025-10-20 22:20:19 +01:00
Julian Stirling
635375a012 Fix assumption that CSM was a numpy array not a list 2025-10-20 16:40:41 +01:00
Julian Stirling
b314ced4f7 Final Range of motion tests 2025-10-17 17:31:34 +01:00
Julian Stirling
a935105e56 Update docstrings in response to review. 2025-10-17 15:26:39 +01:00
Julian Stirling
30217a4c38 Add tests for initial moves at start of ROM test 2025-10-17 15:19:06 +01:00
Julian Stirling
95f5bbb16c Ensure ROM z-predict returns an integer and add more tests. 2025-10-17 15:19:06 +01:00
Julian Stirling
3d49cbf921 Adding even more ROM tests 2025-10-17 15:19:06 +01:00
Julian Stirling
664c7de5f8 Add more ROM tests 2025-10-17 15:19:06 +01:00
Julian Stirling
50d6298c06 Start updating ROM tests for new structure 2025-10-17 15:19:06 +01:00
Julian Stirling
8a1acbea28 Refactor as class methods, renaming methods based on intended purpose.
This was a very big commit as starting the refactor broke everything
2025-10-17 15:19:06 +01:00
Julian Stirling
f1730ff2c0 Tidy up ROM action and add a lock 2025-10-17 15:19:06 +01:00
Julian Stirling
ee76a46882 Move actions to top of ROM thing 2025-10-17 15:19:06 +01:00
Julian Stirling
23c4ac6c18 Adjust data types and remove need to reset tracker 2025-10-17 15:19:06 +01:00
Julian Stirling
9fe6ad8efb Reduce argument numbers with data class and constants 2025-10-17 15:19:06 +01:00
Julian Stirling
8a0836f368 Fix some annotations, arguments, and docstring formatting 2025-10-17 15:19:06 +01:00
jaknapper
19b2afe7d7 Logging fixes 2025-10-17 15:19:06 +01:00
Chish36
3f29e6ccea Changed variable name, fixed parasitic error 2025-10-17 15:19:06 +01:00
Chish36
1e7ad7bf29 Fixed ruff errors 2025-10-17 15:19:06 +01:00
Ben Chisholm
e5b0c7f049 Created function to collate data with unit test for it 2025-10-17 15:19:06 +01:00
Chish36
61167888a6 Fixed pydoctor errors 2025-10-17 15:19:06 +01:00
Chish36
094cb94da8 Ruff formatting 2025-10-17 15:19:06 +01:00
Chish36
773f19ee36 Added unit test for parasitic error 2025-10-17 15:19:06 +01:00
Chish36
e3a17240db Typehint given to data 2025-10-17 15:19:06 +01:00
Chish36
6bed02eccf Removed assert statement and replaced with custom exception 2025-10-17 15:19:06 +01:00
Chish36
1e7f62f8ad 2 unit tests added. Added a dummy matrix to mock_csm and changed position in mock_stage to a dictionary. 2025-10-17 15:19:06 +01:00
Chish36
ab9a324122 Typehint added and import removed. 2025-10-17 15:19:06 +01:00
Chish36
1afaa53413 Removed cv2 resize 2025-10-17 15:19:06 +01:00
Chish36
3a0961e9dc Clearer dictionary keys 2025-10-17 15:19:06 +01:00
Chish36
8dad346320 Made changes to docstrings and a few minor code changes. 2025-10-17 15:19:06 +01:00
Chish36
875bf1a6de Fixed ruff format errors 2025-10-17 15:19:06 +01:00
Chish36
e95f31d832 Resolved data tracking error. 2025-10-17 15:19:06 +01:00
Chish36
f501e7741d More refactoring 2025-10-17 15:19:06 +01:00
Chish36
024c74f67b More docstrings and comments. Removed json dump to openflexure folder. 2025-10-17 15:19:06 +01:00
Chish36
4cde2d5cd1 Changed typehints to literal for axis and direction 2025-10-17 15:19:06 +01:00
Chish36
897cb022b1 Improved code readability 2025-10-17 15:19:06 +01:00
Chish36
d6c47bd43e Ruff formatting stuff 2025-10-17 15:19:06 +01:00
Chish36
6579a65f84 Made changes based on ruff-lint-increased feedback 2025-10-17 15:19:06 +01:00
Chish36
32129125d6 Fixed spelling 2025-10-17 15:19:06 +01:00
Chish36
8ce7f9f779 Removed empty lines 2025-10-17 15:19:06 +01:00
Chish36
d035b186a2 Updated docstrings 2025-10-17 15:19:06 +01:00
Chish36
f0a67bac19 Type set and added default values to data tracker class 2025-10-17 15:19:06 +01:00
Chish36
4106d0348c Delta is tracked with class now 2025-10-17 15:19:06 +01:00
Chish36
63bd34f548 Removed focus_data 2025-10-17 15:19:06 +01:00