rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review of branch calibration-wizard-refactor

Browse source 
Co-authored-by: Joe Knapper <joe.knapper@glasgow.ac.uk>
This commit is contained in:
Julian Stirling 2025-10-23 17:23:37 +00:00
parent a215d301ae
commit c41f9aa052
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
webapp/src/components/modalComponents/calibrationWizardComponents/README.md
View file

@ -19,7 +19,7 @@ None of these individual steps makes sense in the wizard on their own, hence the
- Have a consistent subtitle during a task - Have a consistent subtitle during a task
- Skip entire task rather than make the user click next through each pane of the task (not yet implemented) - Skip entire task rather than make the user click next through each pane of the task (not yet implemented)
Some simple task such as the welcome screen will have only one step. Some simple tasks such as the welcome screen will have only one step.
## Components ## Components
@ -32,8 +32,8 @@ The calibration wizard is a modal. The top level component in `calibrationWizard
* Checking which Things that have calibration tasks are on the server * Checking which Things that have calibration tasks are on the server
* Checking which of these Things need calibrating * Checking which of these Things need calibrating
* Starting modal on startup if not all Things are calibrated (with a welcome screen and just those tasks) * Starting modal on startup if not all Things are calibrated (with a welcome screen and just those tasks)
* Starting the modal when launched from settings, with all tasks but now welcome screen. * Starting the modal when launched from settings, with all tasks but no welcome screen.
* Before starting the modal a list of task components is dynamically generated. * Before starting the modal, a list of task components is dynamically generated.
### The main task component ### The main task component
@ -47,7 +47,7 @@ Examples of this pattern are in `cameraCalibrationTask.vue` and `cameraStageMapp
### The single step task component ### The single step task component
For simple tasks with only one step there is no need to make both a specific task component instead `singleStepTask.vue` can be used, the step component can be supplied as a prop. For simple tasks with only one step there is no need to make both a specific task component. Instead `singleStepTask.vue` can be used, the step component can be supplied as a prop.
This is used in the main wizard to create the welcome screen and the final page. This is used in the main wizard to create the welcome screen and the final page.

2
webapp/src/components/modalComponents/calibrationWizardComponents/cameraCalibrationSteps/camCalibrationExplanation.vue
View file

@ -7,7 +7,7 @@
</p> </p>
<ul class="uk-list uk-list-bullet"> <ul class="uk-list uk-list-bullet">
<li>Remove any samples from your microscope</li> <li>Remove any samples from your microscope</li>
<li>Ensure your illumination is on, well focussed, and centred.</li> <li>Ensure your illumination is on, well focused, and centred.</li>
</ul> </ul>
</div> </div>
</template> </template>