From c41f9aa052287c17254eb24b2ffd8a21a655f078 Mon Sep 17 00:00:00 2001 From: Julian Stirling Date: Thu, 23 Oct 2025 17:23:37 +0000 Subject: [PATCH] Apply suggestions from code review of branch calibration-wizard-refactor Co-authored-by: Joe Knapper --- .../modalComponents/calibrationWizardComponents/README.md | 8 ++++---- .../cameraCalibrationSteps/camCalibrationExplanation.vue | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/webapp/src/components/modalComponents/calibrationWizardComponents/README.md b/webapp/src/components/modalComponents/calibrationWizardComponents/README.md index ae12abdf..65b58c1e 100644 --- a/webapp/src/components/modalComponents/calibrationWizardComponents/README.md +++ b/webapp/src/components/modalComponents/calibrationWizardComponents/README.md @@ -19,7 +19,7 @@ None of these individual steps makes sense in the wizard on their own, hence the - Have a consistent subtitle during a task - Skip entire task rather than make the user click next through each pane of the task (not yet implemented) -Some simple task such as the welcome screen will have only one step. +Some simple tasks such as the welcome screen will have only one step. ## Components @@ -32,8 +32,8 @@ The calibration wizard is a modal. The top level component in `calibrationWizard * Checking which Things that have calibration tasks are on the server * Checking which of these Things need calibrating * Starting modal on startup if not all Things are calibrated (with a welcome screen and just those tasks) -* Starting the modal when launched from settings, with all tasks but now welcome screen. -* Before starting the modal a list of task components is dynamically generated. +* Starting the modal when launched from settings, with all tasks but no welcome screen. +* Before starting the modal, a list of task components is dynamically generated. ### The main task component @@ -47,7 +47,7 @@ Examples of this pattern are in `cameraCalibrationTask.vue` and `cameraStageMapp ### The single step task component -For simple tasks with only one step there is no need to make both a specific task component instead `singleStepTask.vue` can be used, the step component can be supplied as a prop. +For simple tasks with only one step there is no need to make both a specific task component. Instead `singleStepTask.vue` can be used, the step component can be supplied as a prop. This is used in the main wizard to create the welcome screen and the final page. diff --git a/webapp/src/components/modalComponents/calibrationWizardComponents/cameraCalibrationSteps/camCalibrationExplanation.vue b/webapp/src/components/modalComponents/calibrationWizardComponents/cameraCalibrationSteps/camCalibrationExplanation.vue index 8cadb948..09fb6dc6 100644 --- a/webapp/src/components/modalComponents/calibrationWizardComponents/cameraCalibrationSteps/camCalibrationExplanation.vue +++ b/webapp/src/components/modalComponents/calibrationWizardComponents/cameraCalibrationSteps/camCalibrationExplanation.vue @@ -7,7 +7,7 @@