rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Squash some TODOs

Browse source
This commit is contained in:
Julian Stirling 2025-08-04 11:10:21 +01:00
parent 4e9b07c78f
commit 7d83aadf8d
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/openflexure_microscope_server/stitching.py
View file

@ -10,6 +10,7 @@ from typing import Optional, Any
import threading import threading
import subprocess import subprocess
import os import os
from io import TextIOWrapper
import shlex import shlex
import time import time
@ -324,8 +325,7 @@ class FinalStitcher(BaseStitcher):
# Print everything in the buffer when program finishes # Print everything in the buffer when program finishes
self.log_buffer(process.stdout) self.log_buffer(process.stdout)
def log_buffer(self, buffer): def log_buffer(self, buffer: TextIOWrapper):
# TODO work out type
"""Log everything in the buffer at INFO level.""" """Log everything in the buffer at INFO level."""
while line := buffer.readline(): while line := buffer.readline():
self.logger.info(line) self.logger.info(line)

2
src/openflexure_microscope_server/things/smart_scan.py
View file

@ -699,8 +699,6 @@ class SmartScanThing(lt.Thing):
Note that as this is a lt.thing_action it needs the logger passed as Note that as this is a lt.thing_action it needs the logger passed as
a variable if called from another thing action a variable if called from another thing action
""" """
# TODO tidy this function
# TODO handle if json_path is None (easier once tidied)
scan_data_dict = self._scan_dir_manager.get_scan_data_dict(scan_name) scan_data_dict = self._scan_dir_manager.get_scan_data_dict(scan_name)
if scan_data_dict is None: if scan_data_dict is None:
logger.warning("Couldn't read scan data it may be missing or corrupt.") logger.warning("Couldn't read scan data it may be missing or corrupt.")