From 7d83aadf8d240b2cb07a4007cd44be596747137b Mon Sep 17 00:00:00 2001 From: Julian Stirling Date: Mon, 4 Aug 2025 11:10:21 +0100 Subject: [PATCH] Squash some TODOs --- src/openflexure_microscope_server/stitching.py | 4 ++-- src/openflexure_microscope_server/things/smart_scan.py | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/openflexure_microscope_server/stitching.py b/src/openflexure_microscope_server/stitching.py index 47c61cca..225a0666 100644 --- a/src/openflexure_microscope_server/stitching.py +++ b/src/openflexure_microscope_server/stitching.py @@ -10,6 +10,7 @@ from typing import Optional, Any import threading import subprocess import os +from io import TextIOWrapper import shlex import time @@ -324,8 +325,7 @@ class FinalStitcher(BaseStitcher): # Print everything in the buffer when program finishes self.log_buffer(process.stdout) - def log_buffer(self, buffer): - # TODO work out type + def log_buffer(self, buffer: TextIOWrapper): """Log everything in the buffer at INFO level.""" while line := buffer.readline(): self.logger.info(line) diff --git a/src/openflexure_microscope_server/things/smart_scan.py b/src/openflexure_microscope_server/things/smart_scan.py index a01d014f..2dbde354 100644 --- a/src/openflexure_microscope_server/things/smart_scan.py +++ b/src/openflexure_microscope_server/things/smart_scan.py @@ -699,8 +699,6 @@ class SmartScanThing(lt.Thing): Note that as this is a lt.thing_action it needs the logger passed as a variable if called from another thing action """ - # TODO tidy this function - # TODO handle if json_path is None (easier once tidied) scan_data_dict = self._scan_dir_manager.get_scan_data_dict(scan_name) if scan_data_dict is None: logger.warning("Couldn't read scan data it may be missing or corrupt.")