rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review of branch temperature-ccm

Browse source 
Co-authored-by: Richard Bowman <richard.bowman@cantab.net>
This commit is contained in:
Julian Stirling 2025-11-07 11:32:32 +00:00
parent f432247446
commit 5c56c1e851
2 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/openflexure_microscope_server/things/camera/picamera_tuning_file_utils.py
View file

@ -101,7 +101,11 @@ def set_lst(
) -> dict: ) -> dict:
"""Update the ``rpi.alsc`` section of with new lens shading tables. """Update the ``rpi.alsc`` section of with new lens shading tables.
Only one set of tables is set so no adaptive lens shading will be used. Only one set of tables is set so that the camera pipeline does not adaptively
switch between lens shading tables based on its estimation of colour temperature.
Also ``n_iter`` is set to 0 so that the pipeline doesn't perform an iterative
adaption of our table to try to "correct" if interprets the image as having
different types of lighting.
:param tuning: The current tuning file. :param tuning: The current tuning file.
:param luminance: The table of luminance values, as (12, 16) numpy array. Or None :param luminance: The table of luminance values, as (12, 16) numpy array. Or None
@ -207,7 +211,7 @@ def set_ccm(
tuning: dict, tuning: dict,
col_corr_matrix: list, col_corr_matrix: list,
) -> dict: ) -> dict:
"""Update the ``rpi.alsc`` section of a camera tuning dict set the colour correction matrix. """Update the ``rpi.ccm`` section of a camera tuning dict set the colour correction matrix.
:param tuning: The current tuning dict :param tuning: The current tuning dict
:param col_corr_matrix: The colour correction matrix to set :param col_corr_matrix: The colour correction matrix to set

6
src/openflexure_microscope_server/things/camera/tuning_files/vc4/README.md
View file

@ -6,7 +6,7 @@ More data is available in this datasheet: https://datasheets.raspberrypi.com/cam
## version: ## version:
This needs to be 2.0, version one was a normal dictionary of algorithms, tather than this current structure with the algorithms as a list. This needs to be 2.0, version one was a normal dictionary of algorithms, rather than this current structure with the algorithms as a list.
## target ## target
@ -43,13 +43,13 @@ Values from the default tuning files for imx219 and imx477 are:
"reference_slope": 3.67 "reference_slope": 3.67
``` ```
These can be optimised using the methods in the camera tuning tool shipped with libcamera. Though most of the camera tuning tool methods make assumptions that are invalid for a microscope. As such any tuning would further consideration. These can be optimised using the methods in the camera tuning tool shipped with libcamera. Though most of the camera tuning tool methods make assumptions that are invalid for a microscope. As such any tuning would need further consideration.
### rpi.geq - Green Equalisation ### rpi.geq - Green Equalisation
#### The problems with green equalisation #### The problems with green equalisation
This tried to calculate whether adjacent grren pixels should be equal. This interacts very porly with the chief ray angle compesation when using the camera. The imx219 has a lenslet array: This tried to calculate whether adjacent grren pixels should be equal. This interacts very porly with the chief ray angle compensation when using the camera. The imx219 has a lenslet array:
![](../../../../../../docs/images/ChiefRayAngle.png) ![](../../../../../../docs/images/ChiefRayAngle.png)