diff --git a/src/openflexure_microscope_server/things/camera/picamera_tuning_file_utils.py b/src/openflexure_microscope_server/things/camera/picamera_tuning_file_utils.py index 495f55b5..71960441 100644 --- a/src/openflexure_microscope_server/things/camera/picamera_tuning_file_utils.py +++ b/src/openflexure_microscope_server/things/camera/picamera_tuning_file_utils.py @@ -101,7 +101,11 @@ def set_lst( ) -> dict: """Update the ``rpi.alsc`` section of with new lens shading tables. - Only one set of tables is set so no adaptive lens shading will be used. + Only one set of tables is set so that the camera pipeline does not adaptively + switch between lens shading tables based on its estimation of colour temperature. + Also ``n_iter`` is set to 0 so that the pipeline doesn't perform an iterative + adaption of our table to try to "correct" if interprets the image as having + different types of lighting. :param tuning: The current tuning file. :param luminance: The table of luminance values, as (12, 16) numpy array. Or None @@ -207,7 +211,7 @@ def set_ccm( tuning: dict, col_corr_matrix: list, ) -> dict: - """Update the ``rpi.alsc`` section of a camera tuning dict set the colour correction matrix. + """Update the ``rpi.ccm`` section of a camera tuning dict set the colour correction matrix. :param tuning: The current tuning dict :param col_corr_matrix: The colour correction matrix to set diff --git a/src/openflexure_microscope_server/things/camera/tuning_files/vc4/README.md b/src/openflexure_microscope_server/things/camera/tuning_files/vc4/README.md index 8554e440..9f02aeec 100644 --- a/src/openflexure_microscope_server/things/camera/tuning_files/vc4/README.md +++ b/src/openflexure_microscope_server/things/camera/tuning_files/vc4/README.md @@ -6,7 +6,7 @@ More data is available in this datasheet: https://datasheets.raspberrypi.com/cam ## version: -This needs to be 2.0, version one was a normal dictionary of algorithms, tather than this current structure with the algorithms as a list. +This needs to be 2.0, version one was a normal dictionary of algorithms, rather than this current structure with the algorithms as a list. ## target @@ -43,13 +43,13 @@ Values from the default tuning files for imx219 and imx477 are: "reference_slope": 3.67 ``` -These can be optimised using the methods in the camera tuning tool shipped with libcamera. Though most of the camera tuning tool methods make assumptions that are invalid for a microscope. As such any tuning would further consideration. +These can be optimised using the methods in the camera tuning tool shipped with libcamera. Though most of the camera tuning tool methods make assumptions that are invalid for a microscope. As such any tuning would need further consideration. ### rpi.geq - Green Equalisation #### The problems with green equalisation -This tried to calculate whether adjacent grren pixels should be equal. This interacts very porly with the chief ray angle compesation when using the camera. The imx219 has a lenslet array: +This tried to calculate whether adjacent grren pixels should be equal. This interacts very porly with the chief ray angle compensation when using the camera. The imx219 has a lenslet array: ![](../../../../../../docs/images/ChiefRayAngle.png)