rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review of branch start-gallery-thing

Browse source 
Co-authored-by: Joe Knapper <joe.knapper@glasgow.ac.uk>
This commit is contained in:
Julian Stirling 2026-05-07 08:04:41 +00:00
parent 85299e5a88
commit 1b69b19ec3
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/unit_tests/test_gallery.py
View file

@ -23,7 +23,7 @@ class MockGalleryData(BaseModel):
class MinimalGalleryClass: class MinimalGalleryClass:
"""A class that provides data to the gallery needs but is NOT a thing. """A class that provides data to the gallery but is NOT a thing.
This should fail the protocol check as it is not an OFMThing This should fail the protocol check as it is not an OFMThing
""" """
@ -38,7 +38,7 @@ class MinimalGalleryClass:
class MinimalGallerySource(OFMThing, MinimalGalleryClass): class MinimalGallerySource(OFMThing, MinimalGalleryClass):
"""Minimal example of a Thing that can show in the gallery. """Minimal example of a Thing that can show data in the gallery.
Mixes MinimalGalleryClass into OFMThing to be recognised by the protocol. Mixes MinimalGalleryClass into OFMThing to be recognised by the protocol.
""" """
@ -49,7 +49,7 @@ class MinimalGallerySource(OFMThing, MinimalGalleryClass):
class BadGallerySource(OFMThing): class BadGallerySource(OFMThing):
"""An OFMThing that almost defines enough to show in the gallery. """An OFMThing that almost defines enough to show in the gallery.
Shouldn't math the protocol as ``gallery_data_name`` is missing. Shouldn't match the protocol as ``gallery_data_name`` is missing.
""" """
show_in_gallery = True show_in_gallery = True
@ -98,7 +98,7 @@ def test_gallery_thing_finds_all_providers(simulation_test_env):
def test_gallery_logs_for_bad_providers(caplog): def test_gallery_logs_for_bad_providers(caplog):
"""Test that an error is logged if a gallery source doesn't match the protocol.""" """Test that an error is logged if a gallery source doesn't match the protocol."""
# Create a config with the minimal and the bad thing # Create a config with the minimal Thing and the bad Thing
things = { things = {
"minimal_thing": MinimalGallerySource, "minimal_thing": MinimalGallerySource,
"bad_thing": BadGallerySource, "bad_thing": BadGallerySource,