From 1b69b19ec30ba0a9611d33b9d8db6661997ab934 Mon Sep 17 00:00:00 2001 From: Julian Stirling Date: Thu, 7 May 2026 08:04:41 +0000 Subject: [PATCH] Apply suggestions from code review of branch start-gallery-thing Co-authored-by: Joe Knapper --- tests/unit_tests/test_gallery.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/unit_tests/test_gallery.py b/tests/unit_tests/test_gallery.py index f2b239d6..043b03a3 100644 --- a/tests/unit_tests/test_gallery.py +++ b/tests/unit_tests/test_gallery.py @@ -23,7 +23,7 @@ class MockGalleryData(BaseModel): class MinimalGalleryClass: - """A class that provides data to the gallery needs but is NOT a thing. + """A class that provides data to the gallery but is NOT a thing. This should fail the protocol check as it is not an OFMThing """ @@ -38,7 +38,7 @@ class MinimalGalleryClass: class MinimalGallerySource(OFMThing, MinimalGalleryClass): - """Minimal example of a Thing that can show in the gallery. + """Minimal example of a Thing that can show data in the gallery. Mixes MinimalGalleryClass into OFMThing to be recognised by the protocol. """ @@ -49,7 +49,7 @@ class MinimalGallerySource(OFMThing, MinimalGalleryClass): class BadGallerySource(OFMThing): """An OFMThing that almost defines enough to show in the gallery. - Shouldn't math the protocol as ``gallery_data_name`` is missing. + Shouldn't match the protocol as ``gallery_data_name`` is missing. """ show_in_gallery = True @@ -98,7 +98,7 @@ def test_gallery_thing_finds_all_providers(simulation_test_env): def test_gallery_logs_for_bad_providers(caplog): """Test that an error is logged if a gallery source doesn't match the protocol.""" - # Create a config with the minimal and the bad thing + # Create a config with the minimal Thing and the bad Thing things = { "minimal_thing": MinimalGallerySource, "bad_thing": BadGallerySource,