fafo/jeol-t330a
11
0
Fork 0
Code Issues 5 Pull requests 2 Actions Packages Projects Releases Wiki Activity

Add hysteresis to vacuum thresholds and also fix the web-fronted layout #7

Merged
q3k merged 5 commits from hysteresis into main 2024-10-04 21:32:08 +00:00
Conversation 1 Commits 5 Files changed 4 +70 -29
rahix commented 2024-10-04 21:20:58 +00:00
Owner
Copy link
No description provided.
rahix added the
succd
 label 2024-10-04 21:20:58 +00:00
rahix added 4 commits 2024-10-04 21:20:59 +00:00 
Use CSS grids to all information on a single screen if possible.  There
is a breakpoint for smaller screens.
Make sure the table size doesn't dynamically jiggle with movement of
width changes of the load-average value.
Add a hysteresis value that can be optionally configured for
thresholdOutput blocks.  This will hopefully help to prevent jumping
outputs from feedback that is caused by the thresholdOutput itself.
succd: Configure hysteresis for rough and high thresholds
All checks were successful
/ test (push) Successful in 12s
Details
/ test (pull_request) Successful in 10s
Details
c9085ae769 
Add CLI flags for rough and high hysteresis and configure default values
based on experiments.
rahix requested review from q3k 2024-10-04 21:21:06 +00:00
rahix force-pushed hysteresis from c9085ae769 to 367e4c43a6 2024-10-04 21:22:11 +00:00 Compare
rahix commented 2024-10-04 21:23:09 +00:00
Author
Owner
Copy link

New layout:

image
New layout: <img width="1404" alt="image" src="/attachments/95ce4beb-db53-4503-ae17-65be59326267">
image.png
99 KiB
q3k requested changes 2024-10-04 21:26:17 +00:00
Dismissed
succbone/succd/index.html Outdated
@ -72,3 +61,1 @@
</tr>
</table>
<div style="margin: 2em; clear: both; display: grid; grid-template-columns: repeat(auto-fit, minmax(50em, 1fr)); column-gap: 2em; row-gap: 2em;">
q3k commented 2024-10-04 21:25:08 +00:00
Owner
Copy link

Create CSS class for this instead of the massive inlined style.

Create CSS class for this instead of the massive inlined style.
rahix marked this conversation as resolved
rahix force-pushed hysteresis from 367e4c43a6 to e2fc15ed9b 2024-10-04 21:30:45 +00:00 Compare
rahix requested review from q3k 2024-10-04 21:30:57 +00:00
q3k approved these changes 2024-10-04 21:31:48 +00:00
q3k merged commit e2fc15ed9b into main 2024-10-04 21:32:08 +00:00
rahix deleted branch hysteresis 2024-10-04 21:33:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
q3k
Labels
Clear labels   
evac-controller

Related to the JEOL evacuation controller

  
succbone

Related to the hardware side of succbone

  
succd

Related to the succbone control daemon

No labels
evac-controller
succbone
succd
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fafo/jeol-t330a#7
No description provided.
Delete branch "hysteresis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?