rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Start modals on mount, not create

Browse source 
The calibration modal was not starting properly, because
the component was not mounted when its show method
was called. Calling it from the `mounted` method solves
the problem and we don't get the error.

I'm not 100% sure this was introduced by refactoring the
taskSubmitter, though it's possible. However, I think the
fix is uncontroversial and it should probably have been there
all along.
This commit is contained in:
Richard Bowman 2024-02-29 22:40:41 +00:00
parent fb07343cdd
commit fef53c1176
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
webapp/src/components/appContent.vue
View file

@ -253,12 +253,6 @@ export default {
...mapState({ imjoyEnabled: "imjoyEnabled" }) ...mapState({ imjoyEnabled: "imjoyEnabled" })
}, },
created: function() {
if (this.$store.getters.ready) {
this.startModals();
}
},
mounted() { mounted() {
// A global signal listener to switch tab // A global signal listener to switch tab
this.$root.$on("globalSwitchTab", tabID => { this.$root.$on("globalSwitchTab", tabID => {
@ -272,6 +266,9 @@ export default {
this.$root.$on("globalDecrementTab", () => { this.$root.$on("globalDecrementTab", () => {
this.incrementTabBy(-1); this.incrementTabBy(-1);
}); });
if (this.$store.getters.ready) {
this.startModals();
}
}, },
methods: { methods: {
@ -289,7 +286,10 @@ export default {
this.currentTab = newId; this.currentTab = newId;
}, },
startModals: function() { startModals: function() {
this.$refs["calibrationModal"].show(); console.log(this.$refs);
let modal = this.$refs.calibrationModal;
console.log("modal", modal);
modal.show();
}, },
enterApp: function() { enterApp: function() {
// Stuff to do once connected and all init modals are finished // Stuff to do once connected and all init modals are finished