Apply suggestions from code review of branch flash-led-sim
Co-authored-by: Julian Stirling <julian@julianstirling.co.uk>
This commit is contained in:
parent
18477a663d
commit
fdf33ce4a8
1 changed files with 4 additions and 6 deletions
|
|
@ -140,7 +140,8 @@ class SimulatedCamera(BaseCamera):
|
||||||
self._capture_thread: Optional[Thread] = None
|
self._capture_thread: Optional[Thread] = None
|
||||||
self._capture_enabled = False
|
self._capture_enabled = False
|
||||||
self.generate_sprites()
|
self.generate_sprites()
|
||||||
self.mult = 1
|
# Whether the LED is on
|
||||||
|
self.led_on = True
|
||||||
|
|
||||||
repeating: bool = lt.property(default=False)
|
repeating: bool = lt.property(default=False)
|
||||||
|
|
||||||
|
|
@ -342,17 +343,14 @@ class SimulatedCamera(BaseCamera):
|
||||||
|
|
||||||
def set_led(self, led_on: bool = True) -> None:
|
def set_led(self, led_on: bool = True) -> None:
|
||||||
"""Set the simulated LED to on or off."""
|
"""Set the simulated LED to on or off."""
|
||||||
if led_on:
|
self.led_on = led_on
|
||||||
self.mult = 1
|
|
||||||
else:
|
|
||||||
self.mult = 0
|
|
||||||
|
|
||||||
def generate_frame(self) -> Image.Image:
|
def generate_frame(self) -> Image.Image:
|
||||||
"""Generate a frame with blobs based on the stage coordinates."""
|
"""Generate a frame with blobs based on the stage coordinates."""
|
||||||
pos = self._stage.instantaneous_position
|
pos = self._stage.instantaneous_position
|
||||||
frame = self.generate_image((pos["y"], pos["x"], pos["z"]))
|
frame = self.generate_image((pos["y"], pos["x"], pos["z"]))
|
||||||
# Simulate LED turning off by setting all channels to 0
|
# Simulate LED turning off by setting all channels to 0
|
||||||
if self.mult == 0:
|
if not self.led_on:
|
||||||
return Image.new(frame.mode, frame.size, 0)
|
return Image.new(frame.mode, frame.size, 0)
|
||||||
return frame
|
return frame
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue