rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tidied up setTabProperty

Browse source 
I was doing nasty things with a for loop - we've replaced it with a
map statement, which achieves the same thing but works better with
Vue.js reactivity.
This commit is contained in:
Richard 2021-05-18 11:52:36 +01:00
parent 3e0be6fa81
commit f9f78b867c
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
openflexure_microscope/api/static/src/store.js
View file

@ -38,20 +38,23 @@ const moduleImjoy = {
}
},
/**
* Set a parameter on any matching tab objects
* Set a parameter on the tab with a given id
*
* Payload should contain:
* tab: ID of the tab to modify (not window_id)
* key: name of the property to add/change
* value: value of the property to add/change
*/
setTabProperty(state, payload) {
let tab = payload.tab;
let key = payload.key;
let value = payload.value;
for (let i = 0; i < state.tabs.length; i++) {
let t = state.tabs[i];
if ((t === tab) | (t.name === tab) | (t.id === tab)) {
state.tabs = state.tabs.map(t => {
if (t.id === tab) {
t[key] = value;
}
state.tabs.splice(i, 1, t); // This should work nicely with reactive stuff
}
//state.tabs = tablist; // This should force an update
return t;
});
}
},
actions: {},