rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Raise warnings if there are unsafe file path elements rather than coercing file paths. Stitching still raises an error if your file name is unsafe

Browse source
This commit is contained in:
Beth Probert 2026-03-09 13:54:43 +00:00
parent 2395234322
commit f67699fbc8
3 changed files with 153 additions and 93 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/openflexure_microscope_server/stitching.py
View file

@ -78,13 +78,14 @@ def validate_command(cmd: list[str]) -> None:
# Check against forbidden commands (case-insensitive)
if element.lower() in FORBIDDEN_COMMANDS:
raise StitcherValidationError(
f"Invalid stiching command: Forbidden element '{element}' detected."
f"Invalid stitching command: Forbidden element '{element}' detected."
)
# Ensure characters are safe for a path component
if element != make_path_safe(element):
_, error_raised = make_path_safe(element)
if error_raised:
raise StitcherValidationError(
f"Invalid stiching command: Element '{element}' contains unsafe characters."
f"Invalid stitching command: Element '{element}' contains unsafe characters."
)
@ -154,7 +155,8 @@ class BaseStitcher:
:raises RuntimeError: if inputs are unsafe.
"""
if self.images_dir != make_path_safe(self.images_dir):
_, error_raised = make_path_safe(self.images_dir)
if error_raised:
raise StitcherValidationError(
"Invalid directory path: Contains unsafe characters."
)