From dfca0ff7e053649a8fc0217ac73aac77463af14b Mon Sep 17 00:00:00 2001 From: Antonio Anaya Date: Thu, 12 Feb 2026 05:03:50 -0600 Subject: [PATCH] ui_migration fix(deps): --preliminary-- Removing deep:true from watchers that are not defined as arrays. Missing type hints in watchers. --- .../labThingsComponents/actionButton.vue | 6 +++--- .../labThingsComponents/actionLogDisplay.vue | 14 ++++++++++---- .../labThingsComponents/actionStatusModal.vue | 1 + .../labThingsComponents/inputFromSchema.vue | 4 ++-- .../scanListComponents/openSeadragonViewer.vue | 1 + 5 files changed, 17 insertions(+), 9 deletions(-) diff --git a/webapp/src/components/labThingsComponents/actionButton.vue b/webapp/src/components/labThingsComponents/actionButton.vue index f4e40beb..7ace877f 100644 --- a/webapp/src/components/labThingsComponents/actionButton.vue +++ b/webapp/src/components/labThingsComponents/actionButton.vue @@ -155,14 +155,14 @@ export default { handler(newval) { this.$emit("update:progress", newval); }, - deep: true, + //deep: true, immediate: true // Optional: triggers immediately on component load }, taskStarted: { handler(newval) { this.$emit("update:taskStarted", newval); }, - deep: true + //deep: true }, taskRunning: { handler(newval) { @@ -180,7 +180,7 @@ export default { handler(newval) { this.$emit("update:taskStatus", newval); }, - deep: true + //deep: true } }, diff --git a/webapp/src/components/labThingsComponents/actionLogDisplay.vue b/webapp/src/components/labThingsComponents/actionLogDisplay.vue index 9fc8680e..fe8d6110 100644 --- a/webapp/src/components/labThingsComponents/actionLogDisplay.vue +++ b/webapp/src/components/labThingsComponents/actionLogDisplay.vue @@ -60,11 +60,17 @@ export default { }, watch: { - log: function () { - this.scrollToBottom(); + log: { + handler() { + this.scrollToBottom(); + }, + deep: true, }, - taskStatus: function () { - this.scrollToBottom(); + taskStatus: { + handler() { + this.scrollToBottom(); + }, + //deep: true, }, }, diff --git a/webapp/src/components/labThingsComponents/actionStatusModal.vue b/webapp/src/components/labThingsComponents/actionStatusModal.vue index 76c77273..1ff79867 100644 --- a/webapp/src/components/labThingsComponents/actionStatusModal.vue +++ b/webapp/src/components/labThingsComponents/actionStatusModal.vue @@ -30,6 +30,7 @@ import ActionProgressBar from "./actionProgressBar.vue"; import ActionLogDisplay from "./actionLogDisplay.vue"; // vue3 migration import { markRaw } from "vue"; +import { eventBus } from "../../eventBus.js"; export default { name: "ActionStatusModal", diff --git a/webapp/src/components/labThingsComponents/inputFromSchema.vue b/webapp/src/components/labThingsComponents/inputFromSchema.vue index be5fe947..a19536f2 100644 --- a/webapp/src/components/labThingsComponents/inputFromSchema.vue +++ b/webapp/src/components/labThingsComponents/inputFromSchema.vue @@ -216,13 +216,13 @@ export default { this.updateIsEdited(); this.resetInternalValue(); }, - deep: true, + //deep: true, }, internalValue: { handler() { this.updateIsEdited(); }, - deep: true, + //deep: true, }, animate(updated) { if (updated) { diff --git a/webapp/src/components/tabContentComponents/scanListComponents/openSeadragonViewer.vue b/webapp/src/components/tabContentComponents/scanListComponents/openSeadragonViewer.vue index 4e410676..6cdfb24b 100644 --- a/webapp/src/components/tabContentComponents/scanListComponents/openSeadragonViewer.vue +++ b/webapp/src/components/tabContentComponents/scanListComponents/openSeadragonViewer.vue @@ -37,6 +37,7 @@ export default { watch: { src: { + deep: true, immediate: true, handler(newVal) { this.loadOpenSeaDragon(newVal);