rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removing mjpeg bitrate setter from UI and Python as it wasn't implemented fully and isn't a setting that should need changing

Browse source
This commit is contained in:
Julian Stirling 2025-06-23 12:39:41 +01:00
parent 72faba0272
commit dd63d74651
2 changed files with 0 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/openflexure_microscope_server/things/camera/picamera.py
View file

@ -177,12 +177,6 @@ class StreamingPiCamera2(BaseCamera):
description="Bitrate for MJPEG stream (None for default)",
)
@mjpeg_bitrate.setter
def mjpeg_bitrate(self, value: Optional[int]):
"""Restart the stream when we set the bitrate"""
with self.picamera(pause_stream=True):
pass # just pausing and restarting the stream is enough.
stream_active = PropertyDescriptor(
bool,
initial_value=False,

50
webapp/src/components/tabContentComponents/settingsComponents/cameraSettings.vue
View file

@ -32,56 +32,6 @@
/>
</div>
</li>
<li class="uk-open">
<a class="uk-accordion-title" href="#">Image Quality</a>
<div class="uk-accordion-content">
<PropertyControl
label="MJPEG Stream Bit Rate"
property-name="mjpeg_bitrate"
thing-name="camera"
:read-back-delay="100"
/>
<PropertyControl
label="MJPEG Stream Resolution"
property-name="stream_resolution"
thing-name="camera"
:read-back-delay="100"
/>
</div>
</li>
<!--
<li>
<a class="uk-accordion-title" href="#">Advanced</a>
<div class="uk-accordion-content">
<div
v-if="picamera.framerate !== undefined"
class="uk-margin-top"
>
<label class="uk-form-label" for="form-stacked-text"
>Camera framerate</label
>
<select
v-model="picamera.framerate"
class="uk-select uk-form-small"
>
<option
v-for="option in framerateOptions"
:key="option.value"
:value="option.value"
>
{{ option.text }}
</option>
</select>
<p class="uk-margin-remove">
This option sets the framerate of the Pi Camera video
encoder. The actual stream framerate is determined by
network speed, and is limited by the encoder framerate.<br />
<b>Lowering framerate may impact fast-autofocus accuracy.</b>
</p>
</div>
</div>
</li>-->
</ul>
</div>
</form>