From 22c1394aadcbcc1348418199647304f07789cad9 Mon Sep 17 00:00:00 2001 From: Julian Stirling Date: Tue, 7 Jul 2026 18:47:35 +0100 Subject: [PATCH 1/2] Ensure CSM calibration pane updates from Skip to Next on successful calibration. --- .../csmSteps/runCsmStep.vue | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue b/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue index 50f5a93a..d73eb7a1 100644 --- a/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue +++ b/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue @@ -17,7 +17,7 @@ @update:task-status="taskStatus = $event" @update:log="log = $event" @task-started="$emit('prevent-navigation', true)" - @finished="$emit('prevent-navigation', false)" + @finished="csmFinished" /> @@ -52,10 +52,26 @@ export default { }, methods: { + /** + * Check is camera stage mapping is calibrated and emit the result to awaiting-user. + * + * "awaiting-user" is used to signal that the user should perform an action before + * continuing. In practice it changes the next button to "skip". + */ async checkCalibrationState() { const needsCal = await this.readThingProperty("camera_stage_mapping", "calibration_required"); this.$emit("awaiting-user", needsCal); }, + /** + * Tuns whenever CSM finishes re-enable navigation and check calibration state. + * + * This happens if the action is cancelled, errors, or completes successfully as it + * is triggered by `finished`. + */ + async csmFinished() { + this.$emit("prevent-navigation", false); + await this.checkCalibrationState(); + }, }, }; From 65530f0406dc7dad3ca59afdd02228362f7f0cf2 Mon Sep 17 00:00:00 2001 From: Joe Knapper Date: Wed, 8 Jul 2026 09:20:09 +0000 Subject: [PATCH 2/2] Apply suggestions from code review of branch csm-skip-button-fix --- .../calibrationWizardComponents/csmSteps/runCsmStep.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue b/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue index d73eb7a1..b275932b 100644 --- a/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue +++ b/webapp/src/components/modalComponents/calibrationWizardComponents/csmSteps/runCsmStep.vue @@ -53,7 +53,7 @@ export default { methods: { /** - * Check is camera stage mapping is calibrated and emit the result to awaiting-user. + * Check if camera stage mapping is calibrated and emit the result to awaiting-user. * * "awaiting-user" is used to signal that the user should perform an action before * continuing. In practice it changes the next button to "skip". @@ -63,7 +63,7 @@ export default { this.$emit("awaiting-user", needsCal); }, /** - * Tuns whenever CSM finishes re-enable navigation and check calibration state. + * Runs whenever CSM finishes. It re-enables navigation and checks calibration state. * * This happens if the action is cancelled, errors, or completes successfully as it * is triggered by `finished`.