From ba76561065f87dab808becec2ac5d1699c21e1eb Mon Sep 17 00:00:00 2001
From: Richard Bowman <richard.bowman@cantab.net>
Date: Fri, 1 Dec 2023 00:54:54 +0000
Subject: [PATCH] Update calibration modal to use cached TDs and new URLs

---
 .../modalComponents/calibrationModal.vue      | 115 +++++-------------
 1 file changed, 31 insertions(+), 84 deletions(-)

diff --git a/webapp/src/components/modalComponents/calibrationModal.vue b/webapp/src/components/modalComponents/calibrationModal.vue
index fab205bf..054ecf85 100644
--- a/webapp/src/components/modalComponents/calibrationModal.vue
+++ b/webapp/src/components/modalComponents/calibrationModal.vue
@@ -146,8 +146,6 @@
 </template>
 
 <script>
-import axios from "axios";
-
 import cameraCalibrationSettings from "../tabContentComponents/settingsComponents/cameraSettingsComponents/cameraCalibrationSettings.vue";
 import CSMCalibrationSettings from "../tabContentComponents/settingsComponents/CSMSettingsComponents/CSMCalibrationSettings.vue";
 import miniStreamDisplay from "../genericComponents/miniStreamDisplay.vue";
@@ -172,57 +170,21 @@ export default {
     return {
       ready: false,
       stepValue: 0,
-      settings: {},
-      config: {}
+      isCSMCalibrated: undefined,
+      isLSTCalibrated: undefined
     };
   },
 
   computed: {
-    settingsUri: function() {
-      return `${this.$store.getters.baseUri}/api/v2/instrument/settings`;
-    },
-    configUri: function() {
-      return `${this.$store.getters.baseUri}/api/v2/instrument/configuration`;
-    },
-    availablePluginTitles: function() {
-      return this.availablePlugins.map(a => a.title);
-    },
-    isCSMCalibrated: function() {
-      if (this.settings.extensions["org.openflexure.camera_stage_mapping"]) {
-        return true;
-      } else {
-        return false;
-      }
-    },
-    isLSTCalibrated: function() {
-      if (
-        this.settings.camera.picamera &&
-        this.settings.camera.picamera.lens_shading_table
-      ) {
-        return true;
-      } else {
-        return false;
-      }
-    },
     canCSMCalibrated: function() {
       // Assert CSM extension is enabled
-      var extensionEnabled = this.availablePluginTitles.includes(
-        "org.openflexure.camera_stage_mapping"
-      );
-      // Assert real stage is connected
-      var stageConnected = this.config.stage.type !== "MissingStage";
-      // Combine
-      return stageConnected && extensionEnabled;
+      return this.thingAvailable("camera_stage_mapping");
     },
     canLSTCalibrated: function() {
       // Assert LST extension is enabled
-      var extensionEnabled = this.availablePluginTitles.includes(
-        "org.openflexure.calibration.picamera"
+      return (
+        "calibrate_lens_shading" in this.thingDescription("camera").actions
       );
-      // Assert real camera is connected
-      var cameraConnected = this.config.camera.type !== "MissingCamera";
-      // Combine
-      return cameraConnected && extensionEnabled;
     },
     isUseful: function() {
       var CSMUseful = this.canCSMCalibrated && !this.isCSMCalibrated;
@@ -236,25 +198,32 @@ export default {
   },
 
   methods: {
-    show: function() {
-      // Get current settings
-      this.getSettings()
-        .then(() => {
-          return this.getConfig();
-        })
-        .then(() => {
-          // Check if this calibration wizard can actually do anything useful
-          if (this.isUseful) {
-            this.ready = true;
-            this.stepValue = 0;
-            // Show the modal
-            var el = this.$refs["calibrationModalEl"];
-            this.showModalElement(el); // Calls the mixin
-          } else {
-            // If not useful, we just return the onClose event immediately
-            this.onHide();
-          }
-        });
+    show: async function() {
+      // Check if the camera and stage are calibrated, if they can be
+      if (this.canCSMCalibrated) {
+        let csm = this.readThingProperty(
+          "camera_stage_mapping",
+          "image_to_stage_displacement_matrix"
+        );
+        this.isCSMCalibrated = Boolean(csm);
+      }
+      if (this.canLSTCalibrated) {
+        this.isLSTCalibrated = this.readThingProperty(
+          "picamera",
+          "lens_shading_is_static"
+        );
+      }
+      // Check if this calibration wizard can actually do anything useful
+      if (this.isUseful) {
+        this.ready = true;
+        this.stepValue = 0;
+        // Show the modal
+        var el = this.$refs["calibrationModalEl"];
+        this.showModalElement(el); // Calls the mixin
+      } else {
+        // If not useful, we just return the onClose event immediately
+        this.onHide();
+      }
     },
 
     hide: function() {
@@ -268,28 +237,6 @@ export default {
       this.$emit("onClose");
     },
 
-    getSettings: function() {
-      return axios
-        .get(this.settingsUri)
-        .then(response => {
-          this.settings = response.data;
-        })
-        .catch(error => {
-          this.modalError(error); // Let mixin handle error
-        });
-    },
-
-    getConfig: function() {
-      return axios
-        .get(this.configUri)
-        .then(response => {
-          this.config = response.data;
-        })
-        .catch(error => {
-          this.modalError(error); // Let mixin handle error
-        });
-    },
-
     decrement: function() {
       if (this.stepValue > 0) {
         this.stepValue = this.stepValue - 1;