rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review of branch jpeg-capture-in-stacking

Browse source
This commit is contained in:
Joe Knapper 2025-06-25 17:32:05 +00:00
parent 761957d7fb
commit b49aecb802
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/openflexure_microscope_server/things/camera/picamera.py
View file

@ -4,7 +4,7 @@ This SubModule interacts with a Raspberry Pi camera using the Picamera2 library.
The Picamera2 library uses LibCamera as the underlying camera stack. This gives us The Picamera2 library uses LibCamera as the underlying camera stack. This gives us
some control of the GPU pipeline for the image. some control of the GPU pipeline for the image.
The API documentation for PiCamera2 is unfortunatly not in a standard auto-generated The API documentation for PiCamera2 is unfortunately not in a standard auto-generated
website. For documentation of the PiCamera2 API there is a PDF called website. For documentation of the PiCamera2 API there is a PDF called
"The Picamera2 Library" available at: "The Picamera2 Library" available at:
https://datasheets.raspberrypi.com/camera/picamera2-manual.pdf https://datasheets.raspberrypi.com/camera/picamera2-manual.pdf
@ -426,7 +426,7 @@ class StreamingPiCamera2(BaseCamera):
""" """
# Buffer count can't be negative, zero, or too high. # Buffer count can't be negative, zero, or too high.
if buffer_count < 1 or buffer_count < 8: if buffer_count < 1 or buffer_count > 8:
# 8 is slightly arbitrary. 6 is the PiCamera default for video # 8 is slightly arbitrary. 6 is the PiCamera default for video
# and the documentation only says that setting values higher gives # and the documentation only says that setting values higher gives
# diminishing returns, and that the true maximum is hardware dependent # diminishing returns, and that the true maximum is hardware dependent