From a15458c02d0b62f0f1d6b1e1169d3d37d30d799a Mon Sep 17 00:00:00 2001 From: Julian Stirling Date: Mon, 12 Jan 2026 21:40:58 +0000 Subject: [PATCH] Apply suggestions from code review of branch Windows-Testing Co-authored-by: Richard Bowman --- tests/unit_tests/test_version_strings.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/unit_tests/test_version_strings.py b/tests/unit_tests/test_version_strings.py index 6c4f935b..f71e59b8 100644 --- a/tests/unit_tests/test_version_strings.py +++ b/tests/unit_tests/test_version_strings.py @@ -59,15 +59,13 @@ def _git(command: str) -> str: def temp_dir(): """Return the path of a temporary directory (set as working dir).""" working_dir = os.getcwd() - try: - with tempfile.TemporaryDirectory() as tmpdir: + with tempfile.TemporaryDirectory() as tmpdir: + try: os.chdir(tmpdir) yield tmpdir + finally: # Change back to working dir before closing context manager or Windows will error os.chdir(working_dir) - finally: - # Ensure changed to working dir - os.chdir(working_dir) @pytest.fixture