rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use safer metadata dependency

Browse source 
Retrieving metadata pre-action risks stale metadata being
returned if DirectThingClients are used. I've switched to
the safer callable dependency, which is guaranteed to be fresh.
This commit is contained in:
Richard Bowman 2023-12-12 23:40:12 +00:00
parent d9711522d5
commit 94e1619056
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/openflexure_microscope_server/things/settings_manager.py
View file

@ -8,7 +8,7 @@ the server.
from collections.abc import Mapping from collections.abc import Mapping
from typing import Any, Mapping, MutableMapping, Optional, Sequence from typing import Any, Mapping, MutableMapping, Optional, Sequence
from fastapi import HTTPException from fastapi import HTTPException
from labthings_fastapi.dependencies.metadata import ThingStates from labthings_fastapi.dependencies.metadata import GetThingStates
from labthings_fastapi.thing import Thing from labthings_fastapi.thing import Thing
from labthings_fastapi.decorators import thing_action, thing_property from labthings_fastapi.decorators import thing_action, thing_property
from pydantic import BaseModel from pydantic import BaseModel
@ -86,9 +86,9 @@ class SettingsManager(Thing):
self.thing_settings["external_metadata"] = metadata self.thing_settings["external_metadata"] = metadata
@thing_action @thing_action
def get_things_state(self, thing_states_metadata: ThingStates) -> Mapping: def get_things_state(self, metadata_getter: GetThingStates) -> Mapping:
"""Metadata summarising the current state of all Things in the server""" """Metadata summarising the current state of all Things in the server"""
return thing_states_metadata return metadata_getter()
@thing_property @thing_property
def external_metadata_in_state(self) -> Sequence[str]: def external_metadata_in_state(self) -> Sequence[str]: