Merge branch 'temporary-scan-captures' into 'master'
Temporary scan captures See merge request openflexure/openflexure-microscope-server!10
This commit is contained in:
Joel Collins
commit
941aadebfe
5 changed files with 34 additions and 92 deletions
|
|
@ -14,7 +14,7 @@ except ImportError:
|
|||
except ImportError:
|
||||
from _thread import get_ident
|
||||
|
||||
from .capture import CaptureObject, capture_from_dict, BASE_CAPTURE_PATH
|
||||
from .capture import CaptureObject, capture_from_dict, BASE_CAPTURE_PATH, TEMP_CAPTURE_PATH
|
||||
from openflexure_microscope.config import USER_CONFIG_DIR
|
||||
from openflexure_microscope.utilities import entry_by_id
|
||||
from openflexure_microscope.lock import StrictLock
|
||||
|
|
@ -111,6 +111,8 @@ class BaseCamera(object):
|
|||
self.paths = {
|
||||
'image': BASE_CAPTURE_PATH,
|
||||
'video': BASE_CAPTURE_PATH,
|
||||
'image_tmp': TEMP_CAPTURE_PATH,
|
||||
'video_tpm': TEMP_CAPTURE_PATH
|
||||
} #: dict: Dictionary of capture paths
|
||||
|
||||
# Capture data
|
||||
|
|
@ -292,7 +294,7 @@ class BaseCamera(object):
|
|||
write_to_file: bool = False,
|
||||
temporary: bool = True,
|
||||
filename: str = None,
|
||||
folder: str = None,
|
||||
folder: str = "",
|
||||
fmt: str = 'jpeg'):
|
||||
|
||||
"""
|
||||
|
|
@ -311,10 +313,8 @@ class BaseCamera(object):
|
|||
logging.debug(filename)
|
||||
|
||||
# Generate folder
|
||||
if folder:
|
||||
folder = os.path.join(self.paths['image'], folder)
|
||||
else:
|
||||
folder = self.paths['image']
|
||||
base_folder = self.paths['image_tmp'] if temporary else self.paths['image']
|
||||
folder = os.path.join(base_folder, folder)
|
||||
|
||||
# Create capture object
|
||||
output = CaptureObject(
|
||||
|
|
@ -357,10 +357,8 @@ class BaseCamera(object):
|
|||
logging.debug(filename)
|
||||
|
||||
# Generate folder
|
||||
if folder:
|
||||
folder = os.path.join(self.paths['video'], folder)
|
||||
else:
|
||||
folder = self.paths['video']
|
||||
base_folder = self.paths['video_tmp'] if temporary else self.paths['video']
|
||||
folder = os.path.join(base_folder, folder)
|
||||
|
||||
# Create capture object
|
||||
output = CaptureObject(
|
||||
|
|
|
|||
|
|
@ -1,6 +1,7 @@
|
|||
import uuid
|
||||
import io
|
||||
import os
|
||||
import shutil
|
||||
import glob
|
||||
import datetime
|
||||
import yaml
|
||||
|
|
@ -25,10 +26,7 @@ def clear_tmp():
|
|||
global TEMP_CAPTURE_PATH
|
||||
|
||||
logging.info("Clearing {}...".format(TEMP_CAPTURE_PATH))
|
||||
files = glob.glob('{}/*'.format(TEMP_CAPTURE_PATH))
|
||||
for f in files:
|
||||
os.remove(f)
|
||||
logging.debug("Removed {}".format(f))
|
||||
shutil.rmtree(TEMP_CAPTURE_PATH)
|
||||
logging.debug("Cleared {}.".format(TEMP_CAPTURE_PATH))
|
||||
|
||||
|
||||
|
|
@ -81,8 +79,8 @@ def capture_from_dict(capture_dict):
|
|||
|
||||
# Get inherent capture information from database
|
||||
capture.file = capture_dict['path']
|
||||
capture.split_file_path(capture.file)
|
||||
capture.temporary = capture_dict['temporary']
|
||||
capture.split_file_path(capture.file)
|
||||
|
||||
if capture.format.upper() in EXIF_FORMATS:
|
||||
md_exif = pull_usercomment_dict(capture.file)
|
||||
|
|
@ -137,9 +135,7 @@ class CaptureObject(object):
|
|||
filename = self.id
|
||||
self.filename = "{}.{}".format(filename, fmt)
|
||||
|
||||
# Create folder path. Default to BASE_CAPTURE_PATH
|
||||
if not folder:
|
||||
folder = BASE_CAPTURE_PATH
|
||||
# Create folder path
|
||||
self.folder = folder
|
||||
|
||||
# Dictionary for storing custom metadata
|
||||
|
|
@ -185,7 +181,7 @@ class CaptureObject(object):
|
|||
file on disk.
|
||||
|
||||
"""
|
||||
self.build_file_path(self.filename, self.folder)
|
||||
self.build_file_path()
|
||||
|
||||
# Byte bytestream properties
|
||||
self.bytestream = io.BytesIO() # Byte bytestream that data will be written to
|
||||
|
|
@ -201,43 +197,30 @@ class CaptureObject(object):
|
|||
# Save initial metadata file
|
||||
self.save_metadata()
|
||||
|
||||
def build_file_path(
|
||||
self,
|
||||
filename: str,
|
||||
folder: str):
|
||||
def build_file_path(self):
|
||||
"""
|
||||
Construct a full file path, based on filename, folder, and file format.
|
||||
Defaults to UUID.
|
||||
|
||||
Args:
|
||||
filename (str): Filename of capture
|
||||
folder (str): Directory on disk to store capture file
|
||||
"""
|
||||
global TEMP_CAPTURE_PATH
|
||||
# TODO: Combine this and split_file_path, and tidy. Let the device (camera) handle folders. This should be more basic.
|
||||
# TODO: Even let the base camera manage moving captures to temp folder
|
||||
# This module will clear out the temp folder, but won't MOVE anything there.
|
||||
# In Base cameras new_image method, the full folder is constructed. Temp folder should be inserted there.
|
||||
|
||||
self.file = os.path.join(folder, filename) # Full file name by joining given folder to given name
|
||||
self.file = os.path.join(self.folder, self.filename) # Full file name by joining given folder to given name
|
||||
|
||||
self.split_file_path(self.file) # Split file path into folder, filename, and basename
|
||||
|
||||
# Check directory is a subdirectory of BASE_CAPTURE_PATH
|
||||
# TODO: Do we need this?
|
||||
if not os.path.commonprefix([self.file, BASE_CAPTURE_PATH]) == BASE_CAPTURE_PATH:
|
||||
raise Exception("Captures cannot be stored in a lower-level directory than {}.".format(BASE_CAPTURE_PATH))
|
||||
|
||||
# Move to tmp directory if not being kept
|
||||
if self.temporary:
|
||||
self.file_notmp = self.file # Store originally defined folder
|
||||
self.filefolder = TEMP_CAPTURE_PATH
|
||||
self.file = os.path.join(self.filefolder, self.filename)
|
||||
|
||||
# Create folder and file
|
||||
if not os.path.exists(self.filefolder):
|
||||
os.makedirs(self.filefolder)
|
||||
|
||||
logging.debug(self.file)
|
||||
logging.debug(self.filename)
|
||||
logging.debug(self.basename)
|
||||
logging.debug(self.filefolder)
|
||||
|
||||
def split_file_path(self, filepath):
|
||||
"""
|
||||
Take a full file path, and split it into separated class properties.
|
||||
|
|
@ -453,13 +436,6 @@ class CaptureObject(object):
|
|||
|
||||
def save_file(self) -> bool:
|
||||
"""Write the StreamObjects bytestream to a file."""
|
||||
if self.temporary: # If capture is currently temporary
|
||||
self.load_file() # Load data from tmp file into bytestream, if tmp file exists
|
||||
self.temporary = False # Flag as kept on disk
|
||||
self.file = self.file_notmp # Reset file path to non-temporary path
|
||||
self.split_file_path(self.file) # Set split properties based on new path
|
||||
logging.info("Moved temporary file out to {}".format(self.file))
|
||||
|
||||
if self.stream_exists: # If there's a bytestream to save
|
||||
with open(self.file, 'ab') as f: # Load file as bytes
|
||||
logging.debug("Writing bytestream to file {}".format(self.file))
|
||||
|
|
@ -509,6 +485,7 @@ class CaptureObject(object):
|
|||
"""Both clear the bytestream, and delete any associated on-disk data."""
|
||||
logging.info("Closing {}".format(self.id))
|
||||
self.delete_stream()
|
||||
# Delete the file from disk if temporary
|
||||
if self.temporary:
|
||||
self.delete()
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue