Apply suggestions from code review of branch sigkill-handling
Co-authored-by: Beth Probert <beth_probert@outlook.com>
This commit is contained in:
parent
0618263830
commit
91075af70e
1 changed files with 1 additions and 3 deletions
|
|
@ -11,7 +11,6 @@ import os
|
||||||
import shlex
|
import shlex
|
||||||
import signal
|
import signal
|
||||||
import subprocess
|
import subprocess
|
||||||
import sys
|
|
||||||
import threading
|
import threading
|
||||||
from typing import IO, Optional
|
from typing import IO, Optional
|
||||||
|
|
||||||
|
|
@ -222,8 +221,7 @@ class PreviewStitcher(BaseStitcher):
|
||||||
except lt.exceptions.InvocationCancelledError as e:
|
except lt.exceptions.InvocationCancelledError as e:
|
||||||
with self._popen_lock:
|
with self._popen_lock:
|
||||||
if self._popen_obj is not None:
|
if self._popen_obj is not None:
|
||||||
# mypy requires the check to be here
|
if IS_WINDOWS:
|
||||||
if sys.platform == "win32":
|
|
||||||
# Windows has no SIGKILL
|
# Windows has no SIGKILL
|
||||||
self._popen_obj.kill()
|
self._popen_obj.kill()
|
||||||
else:
|
else:
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue