Apply suggestions from code review of branch scan-workflows

Co-authored-by: Joe Knapper <joe.knapper@glasgow.ac.uk>
This commit is contained in:
Julian Stirling 2026-02-06 13:28:30 +00:00
parent 504a47cbf8
commit 8f30f08bdf
3 changed files with 9 additions and 10 deletions

View file

@ -189,15 +189,14 @@ class HistoricScanData(BaseScanData):
@model_validator(mode="before")
@classmethod
def coerce_legacy(cls, data: dict) -> dict:
"""Coerce any legacy data."""
r"""Coerce any scan data from before version 2 into the version 2 format."""
"""Coerce any scan data from before version 2 into the version 2 format."""
# Before the current version no schema_version was set
if "schema_version" in data:
return data
if "correlation_resize" and "overlap" in data:
correlation_resize = data.pop("correlation_resize")
# Note we don't pop overlap is a setting for the legacy workflow as well
# Note we don't pop overlap, as it is a setting for the legacy workflow as well
# as a stitching setting.
# This is done because in future workflows the stitching overlap may be a
# directly set setting or something that is calculated from other settings.