From 6d1f0197fdb957698c9ebbac1fa0b12a6cdffb2a Mon Sep 17 00:00:00 2001
From: Joel Collins <joel@jtcollins.net>
Date: Wed, 18 Nov 2020 16:10:00 +0000
Subject: [PATCH] Removed pointless abstract method implementations

---
 openflexure_microscope/camera/base.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/openflexure_microscope/camera/base.py b/openflexure_microscope/camera/base.py
index 8d63c704..8ef4804c 100644
--- a/openflexure_microscope/camera/base.py
+++ b/openflexure_microscope/camera/base.py
@@ -117,16 +117,10 @@ class BaseCamera(metaclass=ABCMeta):
     @abstractmethod
     def update_settings(self, config: dict):
         """Update settings from a config dictionary"""
-        with self.lock(timeout=None):
-            # Apply valid config params to camera object
-            for key, value in config.items():  # For each provided setting
-                if hasattr(self, key):  # If the instance has a matching property
-                    setattr(self, key, value)  # Set to the target value
 
     @abstractmethod
     def read_settings(self) -> dict:
         """Return the current settings as a dictionary"""
-        return {}
 
     def __enter__(self):
         """Create camera on context enter."""