Apply suggestions from code review of branch refactor/migrate_vuex_to_pinia
Co-authored-by: Julian Stirling <julian@julianstirling.co.uk>
This commit is contained in:
parent
ebd67cd410
commit
67f253eecd
6 changed files with 24 additions and 7 deletions
|
|
@ -104,8 +104,6 @@ export default {
|
|||
...mapWritableState(useSettingsStore, ["navigationInvert"]),
|
||||
},
|
||||
|
||||
// TODO: jogInterval may need to be cleared on "beforeUnmount()"
|
||||
|
||||
methods: {
|
||||
/**
|
||||
* Jog d-pad and focus buttons.
|
||||
|
|
|
|||
|
|
@ -66,10 +66,10 @@ export default {
|
|||
}
|
||||
this.modalConfirm(message).then(
|
||||
() => {
|
||||
this.resetState();
|
||||
this.deleteAllThingDescriptions();
|
||||
// Post and silence errors
|
||||
axios.post(this.thingActionUrl("system", action)).catch(() => {});
|
||||
this.resetState();
|
||||
this.deleteAllThingDescriptions();
|
||||
},
|
||||
() => {},
|
||||
);
|
||||
|
|
|
|||
|
|
@ -42,8 +42,6 @@
|
|||
import propertyControl from "@/components/labThingsComponents/propertyControl.vue";
|
||||
import ServerSpecifiedInterface from "@/components/labThingsComponents/serverSpecifiedInterface.vue";
|
||||
import { useIntersectionObserver } from "@vueuse/core";
|
||||
//import { mapWritableState } from "pinia";
|
||||
//import { useSettingsStore } from "@/stores/settings.js";
|
||||
|
||||
export default {
|
||||
name: "SlideScanControls",
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue