Apply suggestions from code review of branch refactor/migrate_vuex_to_pinia

Co-authored-by: Julian Stirling <julian@julianstirling.co.uk>
This commit is contained in:
Antonio Anaya 2026-04-30 21:24:29 +00:00
parent ebd67cd410
commit 67f253eecd
6 changed files with 24 additions and 7 deletions

View file

@ -68,7 +68,9 @@ export default {
computed: {
propertyDescription: function () {
const td = this.wotStore.thingDescriptions[this.thingName];
// Return `undefined` if the thing doesn't exist or has no properties
if (!td || !td.properties) return undefined;
// JS returns `undefined` if this property name doesn't exist
return td.properties[this.propertyName];
},
},

View file

@ -104,8 +104,6 @@ export default {
...mapWritableState(useSettingsStore, ["navigationInvert"]),
},
// TODO: jogInterval may need to be cleared on "beforeUnmount()"
methods: {
/**
* Jog d-pad and focus buttons.

View file

@ -66,10 +66,10 @@ export default {
}
this.modalConfirm(message).then(
() => {
this.resetState();
this.deleteAllThingDescriptions();
// Post and silence errors
axios.post(this.thingActionUrl("system", action)).catch(() => {});
this.resetState();
this.deleteAllThingDescriptions();
},
() => {},
);

View file

@ -42,8 +42,6 @@
import propertyControl from "@/components/labThingsComponents/propertyControl.vue";
import ServerSpecifiedInterface from "@/components/labThingsComponents/serverSpecifiedInterface.vue";
import { useIntersectionObserver } from "@vueuse/core";
//import { mapWritableState } from "pinia";
//import { useSettingsStore } from "@/stores/settings.js";
export default {
name: "SlideScanControls",