From cbd8b090ece74883648f69689291c071057030a0 Mon Sep 17 00:00:00 2001 From: Richard Bowman Date: Thu, 29 Feb 2024 21:44:39 +0000 Subject: [PATCH 1/4] Replace tasksubmitter with action-button I've changed tasksubmitter to accept a "thing" and "action" rather than a single URL. This seems more in keeping with propertyControl, and eliminates the need for loads of computed properties. I've also deleted (rather than just commenting out) chunks of the web app that are no longer in use. These may be reinstated in the future - but we can get them from git history. It's less confusing not to have vestigial code in the repo. This builds OK but is not, as yet, tested with hardware. --- webapp/src/App.vue | 2 +- webapp/src/components/appContent.vue | 84 +-- .../actionButton.vue} | 18 +- .../actionLogDisplay.vue | 5 +- .../actionProgressBar.vue | 0 .../labThingsComponents/propertyControl.vue | 12 +- .../components/pluginComponents/JsonForm.vue | 249 -------- .../aboutComponents/statusPane.vue | 15 +- .../paneBackgroundDetect.vue | 86 ++- .../captureComponents/paneCapture.vue | 547 ------------------ .../tabContentComponents/extensionContent.vue | 20 +- .../galleryComponents/captureCard.vue | 392 ------------- .../galleryComponents/scanCard.vue | 154 ----- .../galleryComponents/zipDownloader.vue | 163 ------ .../tabContentComponents/galleryContent.vue | 455 --------------- .../navigateComponents/paneNavigate.vue | 88 +-- .../tabContentComponents/scanListContent.vue | 32 +- .../CSMCalibrationSettings.vue | 12 +- .../cameraCalibrationSettings.vue | 84 +-- .../tabContentComponents/settingsContent.vue | 15 +- .../tabContentComponents/slideScanContent.vue | 111 ++-- webapp/src/main.js | 6 +- 22 files changed, 225 insertions(+), 2325 deletions(-) rename webapp/src/components/{genericComponents/taskSubmitter.vue => labThingsComponents/actionButton.vue} (96%) rename webapp/src/components/{genericComponents => labThingsComponents}/actionLogDisplay.vue (92%) rename webapp/src/components/{genericComponents => labThingsComponents}/actionProgressBar.vue (100%) delete mode 100644 webapp/src/components/pluginComponents/JsonForm.vue delete mode 100644 webapp/src/components/tabContentComponents/captureComponents/paneCapture.vue delete mode 100644 webapp/src/components/tabContentComponents/galleryComponents/captureCard.vue delete mode 100644 webapp/src/components/tabContentComponents/galleryComponents/scanCard.vue delete mode 100644 webapp/src/components/tabContentComponents/galleryComponents/zipDownloader.vue delete mode 100644 webapp/src/components/tabContentComponents/galleryContent.vue diff --git a/webapp/src/App.vue b/webapp/src/App.vue index 7fd01adb..e6a4df35 100644 --- a/webapp/src/App.vue +++ b/webapp/src/App.vue @@ -429,7 +429,7 @@ html { padding: 0; } -.image-fit{ +.image-fit { height: 80%; width: 100%; object-fit: contain; diff --git a/webapp/src/components/appContent.vue b/webapp/src/components/appContent.vue index 96aa2217..4a9dd021 100644 --- a/webapp/src/components/appContent.vue +++ b/webapp/src/components/appContent.vue @@ -7,7 +7,6 @@ @@ -41,22 +40,6 @@
- - - {{ - plugin.icon || "extension" - }} - - - - - - - - import( - /* webpackChunkName: "gallery" */ "./tabContentComponents/galleryContent.vue" - ); +// ImJoy is loaded asynchronously to allow it to be disabled if needed const imjoyContent = () => import( /* webpackChunkName: "imjoy" */ "./tabContentComponents/imjoyContent.vue" @@ -197,12 +157,9 @@ export default { tabIcon, tabContent, navigateContent, - captureContent, slideScanContent, viewContent, settingsContent, - galleryContent, - extensionContent, calibrationModal, aboutContent, loggingContent, @@ -211,7 +168,6 @@ export default { }, data: function() { return { - plugins: [], currentTab: "view", bottomTabs: [ { @@ -235,25 +191,11 @@ export default { }, computed: { - pluginsGuiList: function() { - // List of plugin GUIs, obtained from this.plugins values - var pluginGuis = []; - for (let plugin of Object.values(this.plugins)) { - if (plugin.meta.gui) { - pluginGuis.push(plugin.meta.gui); - } - } - return pluginGuis; - }, - tabOrder: function() { var ind = []; for (const tab of this.topTabs) { ind.push(tab.id); } - for (const plugin of this.pluginsGuiList) { - ind.push(plugin.id); - } for (const tab of this.bottomTabs) { ind.push(tab.id); } @@ -272,11 +214,6 @@ export default { icon: "gamepad", component: navigateContent }, - /*{ - id: "gallery", - icon: "photo_library", - component: galleryContent - },*/ { id: "slidescan", icon: "settings_overscan", @@ -318,11 +255,7 @@ export default { created: function() { if (this.$store.getters.ready) { - // Update plugins - this.updatePlugins().then(() => { - // Start initialisation modals - this.startModals(); - }); + this.startModals(); } }, @@ -342,19 +275,6 @@ export default { }, methods: { - updatePlugins: function() { - /*return axios - .get(this.pluginsUri) - .then(response => { - this.plugins = response.data; - }) - .catch(error => { - this.modalError(error); // Let mixin handle error - });*/ - return new Promise(resolve => { - resolve({}); - }); - }, setTab: function(event, tab) { if (!(this.currentTab == tab)) { this.currentTab = tab; diff --git a/webapp/src/components/genericComponents/taskSubmitter.vue b/webapp/src/components/labThingsComponents/actionButton.vue similarity index 96% rename from webapp/src/components/genericComponents/taskSubmitter.vue rename to webapp/src/components/labThingsComponents/actionButton.vue index e682127a..1fae45dd 100644 --- a/webapp/src/components/genericComponents/taskSubmitter.vue +++ b/webapp/src/components/labThingsComponents/actionButton.vue @@ -72,15 +72,19 @@ - - diff --git a/webapp/src/components/tabContentComponents/aboutComponents/statusPane.vue b/webapp/src/components/tabContentComponents/aboutComponents/statusPane.vue index 3a6b5288..dc34291f 100644 --- a/webapp/src/components/tabContentComponents/aboutComponents/statusPane.vue +++ b/webapp/src/components/tabContentComponents/aboutComponents/statusPane.vue @@ -12,12 +12,12 @@
{{ $store.state.origin }} - @@ -83,18 +83,15 @@ - - diff --git a/webapp/src/components/tabContentComponents/extensionContent.vue b/webapp/src/components/tabContentComponents/extensionContent.vue index 7ec6e5fb..3312c10b 100644 --- a/webapp/src/components/tabContentComponents/extensionContent.vue +++ b/webapp/src/components/tabContentComponents/extensionContent.vue @@ -3,23 +3,7 @@
- -
- -
+
@@ -30,7 +14,6 @@ diff --git a/webapp/src/components/tabContentComponents/galleryComponents/scanCard.vue b/webapp/src/components/tabContentComponents/galleryComponents/scanCard.vue deleted file mode 100644 index e6e76075..00000000 --- a/webapp/src/components/tabContentComponents/galleryComponents/scanCard.vue +++ /dev/null @@ -1,154 +0,0 @@ - - - diff --git a/webapp/src/components/tabContentComponents/galleryComponents/zipDownloader.vue b/webapp/src/components/tabContentComponents/galleryComponents/zipDownloader.vue deleted file mode 100644 index 005a18f6..00000000 --- a/webapp/src/components/tabContentComponents/galleryComponents/zipDownloader.vue +++ /dev/null @@ -1,163 +0,0 @@ - - - diff --git a/webapp/src/components/tabContentComponents/galleryContent.vue b/webapp/src/components/tabContentComponents/galleryContent.vue deleted file mode 100644 index 0a6ce4f2..00000000 --- a/webapp/src/components/tabContentComponents/galleryContent.vue +++ /dev/null @@ -1,455 +0,0 @@ - - - - - diff --git a/webapp/src/components/tabContentComponents/navigateComponents/paneNavigate.vue b/webapp/src/components/tabContentComponents/navigateComponents/paneNavigate.vue index 7bf08e45..36d92fe2 100644 --- a/webapp/src/components/tabContentComponents/navigateComponents/paneNavigate.vue +++ b/webapp/src/components/tabContentComponents/navigateComponents/paneNavigate.vue @@ -68,16 +68,18 @@
- - + + /> @@ -109,9 +111,10 @@

- + />

@@ -134,9 +137,9 @@
- + />
-
  • +
  • Image Capture
    - + />
    - + />
  • @@ -194,14 +197,14 @@