From 5296092b6bab385efa7329911b4824894041abd7 Mon Sep 17 00:00:00 2001 From: Julian Stirling Date: Mon, 28 Jul 2025 08:44:41 +0100 Subject: [PATCH] Fix tests now background status settings are returned as dictionaries. --- tests/mock_things/mock_camera.py | 2 +- tests/test_background_detectors.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/mock_things/mock_camera.py b/tests/mock_things/mock_camera.py index 064812d1..81104dde 100644 --- a/tests/mock_things/mock_camera.py +++ b/tests/mock_things/mock_camera.py @@ -23,6 +23,6 @@ class MockCameraThing: background_detector_status = BackgroundDetectorStatus( ready=True, - settings=ColourChannelDetectSettings(), + settings=ColourChannelDetectSettings().model_dump(), settings_schema={"fake": "schema"}, ) diff --git a/tests/test_background_detectors.py b/tests/test_background_detectors.py index 4fc2f395..956a96e9 100644 --- a/tests/test_background_detectors.py +++ b/tests/test_background_detectors.py @@ -70,7 +70,8 @@ def test_partial_base_class(background_image): bad_algo1 = BadAlgo1() status = bad_algo1.status assert not status.ready - assert isinstance(status.settings, ColourChannelDetectSettings) + # Check the settings dictionary can be validated as ``ColourChannelDetectSettings`` + ColourChannelDetectSettings(**status.settings) with pytest.raises(NotImplementedError): # Should error on any dictionary input. This simulates loading settings from