From 4910bef71720d182b01e423f34c49b11e9b47865 Mon Sep 17 00:00:00 2001
From: Julian Stirling <julian@julianstirling.co.uk>
Date: Sun, 9 Nov 2025 14:10:27 +0000
Subject: [PATCH] Split the action status modal from the action button

---
 .../labThingsComponents/actionButton.vue      |  88 +++------------
 .../labThingsComponents/actionStatusModal.vue | 105 ++++++++++++++++++
 2 files changed, 121 insertions(+), 72 deletions(-)
 create mode 100644 webapp/src/components/labThingsComponents/actionStatusModal.vue

diff --git a/webapp/src/components/labThingsComponents/actionButton.vue b/webapp/src/components/labThingsComponents/actionButton.vue
index aa4d2265..ede5af16 100644
--- a/webapp/src/components/labThingsComponents/actionButton.vue
+++ b/webapp/src/components/labThingsComponents/actionButton.vue
@@ -11,7 +11,7 @@
         v-if="canTerminate && taskRunning"
         type="button"
         class="uk-button uk-button-danger uk-margin-remove uk-float-right uk-width-1-1"
-        @click="terminateTask()"
+        @click="terminateTask"
       >
         Cancel
       </button>
@@ -27,57 +27,34 @@
           isDisabled ? 'uk-button-disabled' : '',
           buttonPrimary ? 'uk-button-primary' : 'uk-button-default',
         ]"
-        @click="bootstrapTask()"
+        @click="bootstrapTask"
       >
         {{ submitLabel }}
       </button>
     </div>
-
-    <div
-      id="modal-center"
+    <action-status-modal
       ref="statusModal"
-      class=""
-      uk-modal="bg-close: false; esc-close: false; stack: true;"
-    >
-      <div id="status-modal" class="uk-modal-dialog uk-modal-body uk-margin-auto-vertical">
-        <h2>{{ submitLabel }}</h2>
-        <action-log-display :log="log" :task-status="taskStatus" />
-        <div id="progress-and-cancel-row">
-          <div class="stretchy">
-            <action-progress-bar :progress="progress" :task-status="taskStatus" />
-          </div>
-
-          <button
-            v-if="canTerminate && taskRunning"
-            type="button"
-            class="uk-button uk-button-danger not-stretchy"
-            @click="terminateTask()"
-          >
-            Cancel
-          </button>
-          <button
-            v-if="!taskStarted"
-            type="button"
-            class="uk-button not-stretchy"
-            @click="hideModal"
-          >
-            Close
-          </button>
-        </div>
-      </div>
-    </div>
+      :title="submitLabel"
+      :log="log"
+      :progress="progress"
+      :can-terminate="canTerminate"
+      :task-running="taskRunning"
+      :task-started="taskStarted"
+      :task-status="taskStatus"
+      @terminateTask="terminateTask"
+    />
   </div>
 </template>
 
 <script>
 import axios from "axios";
-import UIkit from "uikit";
+
 import ActionProgressBar from "./actionProgressBar.vue";
-import ActionLogDisplay from "./actionLogDisplay.vue";
+import ActionStatusModal from "./actionStatusModal.vue";
 
 export default {
   name: "ActionButton",
-  components: { ActionProgressBar, ActionLogDisplay },
+  components: { ActionProgressBar, ActionStatusModal },
 
   props: {
     action: {
@@ -289,7 +266,7 @@ export default {
       try {
         let response = await axios.post(this.submitUrl, this.submitData);
         if (this.modalProgress) {
-          UIkit.modal(this.$refs.statusModal).show();
+          this.$refs.statusModal.show();
         }
         await this.pollOngoingTask(response.data.id, response.data.href);
       } catch (error) {
@@ -379,11 +356,6 @@ export default {
       return new Promise(checkCondition);
     },
 
-    hideModal() {
-      UIkit.modal(this.$refs.statusModal).hide();
-      this.$root.$emit("modalClosed");
-    },
-
     terminateTask: function () {
       axios.delete(this.taskUrl, { baseURL: this.$store.getters.baseUri });
       this.$root.$emit("modalClosed");
@@ -391,31 +363,3 @@ export default {
   },
 };
 </script>
-
-<style lang="less" scoped>
-@import "../../assets/less/theme.less";
-
-#progress-and-cancel-row {
-  display: flex;
-  flex-flow: row wrap;
-  justify-content: flex-start;
-  align-content: stretch;
-  align-items: center;
-  width: 100%;
-}
-
-#progress-and-cancel-row .stretchy {
-  flex-grow: 1;
-  margin-left: 5px;
-  margin-right: 5px;
-}
-#progress-and-cancel-row .not-stretchy {
-  flex-grow: 0;
-  margin-left: 5px;
-  margin-right: 5px;
-}
-
-#status-modal .log-container {
-  height: 10em;
-}
-</style>
diff --git a/webapp/src/components/labThingsComponents/actionStatusModal.vue b/webapp/src/components/labThingsComponents/actionStatusModal.vue
new file mode 100644
index 00000000..e605305e
--- /dev/null
+++ b/webapp/src/components/labThingsComponents/actionStatusModal.vue
@@ -0,0 +1,105 @@
+<template>
+  <div ref="modal" class="" uk-modal="bg-close: false; esc-close: false; stack: true;">
+    <div id="status-modal" class="uk-modal-dialog uk-modal-body uk-margin-auto-vertical">
+      <h2>{{ title }}</h2>
+      <action-log-display :log="log" :task-status="taskStatus" />
+      <div id="progress-and-cancel-row">
+        <div class="stretchy">
+          <action-progress-bar :progress="progress" :task-status="taskStatus" />
+        </div>
+
+        <button
+          v-if="canTerminate && taskRunning"
+          type="button"
+          class="uk-button uk-button-danger not-stretchy"
+          @click="$emit('terminateTask')"
+        >
+          Cancel
+        </button>
+        <button v-if="!taskStarted" type="button" class="uk-button not-stretchy" @click="hide">
+          Close
+        </button>
+      </div>
+    </div>
+  </div>
+</template>
+
+<script>
+import UIkit from "uikit";
+import ActionProgressBar from "./actionProgressBar.vue";
+import ActionLogDisplay from "./actionLogDisplay.vue";
+
+export default {
+  name: "ActionStatusModal",
+  components: { ActionProgressBar, ActionLogDisplay },
+
+  props: {
+    title: {
+      type: String,
+      required: true,
+    },
+    log: {
+      type: Array,
+      required: true,
+    },
+    progress: {
+      type: Number,
+      required: false,
+      default: null,
+    },
+    canTerminate: {
+      type: Boolean,
+      required: true,
+    },
+    taskRunning: {
+      type: Boolean,
+      required: true,
+    },
+    taskStarted: {
+      type: Boolean,
+      required: true,
+    },
+    taskStatus: {
+      type: String,
+      required: true,
+    },
+  },
+
+  methods: {
+    show() {
+      UIkit.modal(this.$refs.modal).show();
+    },
+    hide() {
+      UIkit.modal(this.$refs.modal).hide();
+      this.$root.$emit("modalClosed");
+    },
+  },
+};
+</script>
+<style lang="less" scoped>
+@import "../../assets/less/theme.less";
+
+#progress-and-cancel-row {
+  display: flex;
+  flex-flow: row wrap;
+  justify-content: flex-start;
+  align-content: stretch;
+  align-items: center;
+  width: 100%;
+}
+
+#progress-and-cancel-row .stretchy {
+  flex-grow: 1;
+  margin-left: 5px;
+  margin-right: 5px;
+}
+#progress-and-cancel-row .not-stretchy {
+  flex-grow: 0;
+  margin-left: 5px;
+  margin-right: 5px;
+}
+
+#status-modal .log-container {
+  height: 10em;
+}
+</style>