From 3b84c266b4635d450c1fdcdc141925895c636d49 Mon Sep 17 00:00:00 2001
From: Joe Knapper <joe.knapper@glasgow.ac.uk>
Date: Mon, 16 Mar 2026 14:31:21 +0000
Subject: [PATCH] Apply suggestions from code review of branch exposure-test

Co-authored-by: Richard Bowman <richard.bowman@cantab.net>
---
 .../things/camera/picamera_recalibrate_utils.py           | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/openflexure_microscope_server/things/camera/picamera_recalibrate_utils.py b/src/openflexure_microscope_server/things/camera/picamera_recalibrate_utils.py
index b5bc6c06..90d6785f 100644
--- a/src/openflexure_microscope_server/things/camera/picamera_recalibrate_utils.py
+++ b/src/openflexure_microscope_server/things/camera/picamera_recalibrate_utils.py
@@ -260,9 +260,11 @@ def _test_exposure_settings(camera: Picamera2, percentile: float) -> _ExposureTe
 
     # A single request, to ensure metadata matches frame
     request = camera.capture_request()
-    metadata = request.get_metadata()
-    image = request.make_array("raw")
-    request.release()
+    try:
+        metadata = request.get_metadata()
+        image = request.make_array("raw")
+    finally:
+        request.release()
     max_brightness = np.percentile(
         _channels_from_bayer_array(image),
         percentile,