Apply suggestions from code review of branch faster-stage-tests
Co-authored-by: Beth Probert <beth_probert@outlook.com>
This commit is contained in:
parent
90dbb35a9e
commit
3a4b99df55
2 changed files with 3 additions and 3 deletions
|
|
@ -14,6 +14,6 @@ import time
|
||||||
class MockCancel:
|
class MockCancel:
|
||||||
"""A class to use when directly calling an action with CancelHook dependency."""
|
"""A class to use when directly calling an action with CancelHook dependency."""
|
||||||
|
|
||||||
def sleep(self, time_in_seconds: float):
|
def sleep(self, time_in_seconds: float) -> None:
|
||||||
"""Sleep for the input number of seconds."""
|
"""Sleep for the input number of seconds."""
|
||||||
time.sleep(time_in_seconds)
|
time.sleep(time_in_seconds)
|
||||||
|
|
|
||||||
|
|
@ -234,7 +234,7 @@ def test_move_relative(stage_client, dummy_stage, path):
|
||||||
inverted when appropriate.
|
inverted when appropriate.
|
||||||
|
|
||||||
NOTE: it is essential that `stage_client` is imported even if any time it is used
|
NOTE: it is essential that `stage_client` is imported even if any time it is used
|
||||||
dummy client could be used. This is because the fixture that creates stage client
|
dummy stage could be used. This is because the fixture that creates stage client
|
||||||
handles adding the dummy_stage to a server. It needs to have been added to a
|
handles adding the dummy_stage to a server. It needs to have been added to a
|
||||||
server for it not to throw errors about not being connected to a server.
|
server for it not to throw errors about not being connected to a server.
|
||||||
"""
|
"""
|
||||||
|
|
@ -295,7 +295,7 @@ def test_move_absolute(stage_client, dummy_stage, path):
|
||||||
inverted when appropriate.
|
inverted when appropriate.
|
||||||
|
|
||||||
NOTE: it is essential that `stage_client` is imported even if any time it is used
|
NOTE: it is essential that `stage_client` is imported even if any time it is used
|
||||||
dummy client could be used. This is because the fixture that creates stage client
|
dummy stage could be used. This is because the fixture that creates stage client
|
||||||
handles adding the dummy_stage to a server. It needs to have been added to a
|
handles adding the dummy_stage to a server. It needs to have been added to a
|
||||||
server for it not to throw errors about not being connected to a server.
|
server for it not to throw errors about not being connected to a server.
|
||||||
"""
|
"""
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue