rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use pytest parametrize for better coverage of forbidden commands and reserved names

Browse source
This commit is contained in:
Beth Probert 2026-03-05 13:55:05 +00:00
parent fa9ea77812
commit 35efba19b8
3 changed files with 49 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/unit_tests/test_stitching.py
View file

@ -16,6 +16,7 @@ from pydantic import BaseModel
import labthings_fastapi as lt
from openflexure_microscope_server.stitching import (
FORBIDDEN_COMMANDS,
BaseStitcher,
FinalStitcher,
PreviewStitcher,
@ -39,22 +40,20 @@ def test_validate_command_success():
validate_command(["--resize", "0.5", "8192"])
def test_validate_command_forbidden():
@pytest.mark.parametrize("cmd_name", FORBIDDEN_COMMANDS)
def test_validate_command_forbidden(cmd_name):
"""Test forbidden commands raise error."""
# As the main command
with pytest.raises(
StitcherValidationError, match="Forbidden element 'sudo' detected"
StitcherValidationError, match=f"Forbidden element '{cmd_name}' detected"
):
validate_command(["sudo", "rm", "-rf", "/"])
validate_command([cmd_name, "some_arg"])
# As an argument (case-insensitive)
with pytest.raises(
StitcherValidationError, match="Forbidden element 'sh' detected"
StitcherValidationError, match=f"Forbidden element '{cmd_name.upper()}' detected"
):
validate_command(["sh", "-c", "whoami"])
with pytest.raises(
StitcherValidationError, match="Forbidden element 'SUDO' detected"
):
validate_command(["SUDO", "ls"])
validate_command(["safe-command", cmd_name.upper()])
def test_base_stitcher():