rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove remaining TODOs in favour of issues

Browse source
This commit is contained in:
Julian Stirling 2025-09-18 14:09:20 +01:00
parent ef89b536fc
commit 338d49f9e6
3 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pyproject.toml
View file

@ -112,7 +112,7 @@ select = [
"B", # Flake8 bugbear "B", # Flake8 bugbear
"A", # Flake8 builtins checker "A", # Flake8 builtins checker
"C", # Flake8 comprehensions "C", # Flake8 comprehensions
# "FIX", #TODO/FIXME's in code. These should be added during development for ongoing tasks. "FIX", #TODO/FIXME's in code. These should be added during development for ongoing tasks.
# If they are not fixed before merge they should be converted to GitLab issues # If they are not fixed before merge they should be converted to GitLab issues
# "LOG", # Flake8 logging issues (pedantic logger formatting issues can be added with "G") # "LOG", # Flake8 logging issues (pedantic logger formatting issues can be added with "G")
# "T20", # Warns for print statements, production code should log # "T20", # Warns for print statements, production code should log

3
src/openflexure_microscope_server/server/legacy_api.py
View file

@ -21,10 +21,9 @@ def add_v2_endpoints(thing_server: lt.ThingServer) -> None:
"""Add the v2 API endpoints for OpenFlexure Connect discoverability.""" """Add the v2 API endpoints for OpenFlexure Connect discoverability."""
app = thing_server.app app = thing_server.app
# TODO: update openflexure connect to make this unnecessary!!
# The endpoints below fool OpenFlexure Connect into thinking we are a # The endpoints below fool OpenFlexure Connect into thinking we are a
# v2 microscope, so we show up correctly. # v2 microscope, so we show up correctly.
# This is necessary until Connect is rebuilt. # This is necessary until Connect is rebuilt. See #557.
@app.get("/routes") @app.get("/routes")
def routes_stub() -> dict[str, dict]: def routes_stub() -> dict[str, dict]:
"""Return a stub list of routes. """Return a stub list of routes.

1
src/openflexure_microscope_server/things/system.py
View file

@ -52,7 +52,6 @@ class OpenFlexureSystem(lt.Thing):
@microscope_id.setter @microscope_id.setter
def microscope_id(self, uuid: UUID) -> None: def microscope_id(self, uuid: UUID) -> None:
# TODO make read only but still settable from disk
self._microscope_id = uuid self._microscope_id = uuid
@lt.thing_property @lt.thing_property