rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove old sangaboard abort_move action as moves are not cancelled with a cancel hook

Browse source
This commit is contained in:
Julian Stirling 2025-07-03 13:16:25 +01:00
parent 4e20067c68
commit 222a0c973d
1 changed files with 0 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/openflexure_microscope_server/things/stage/sangaboard.py
View file

@ -6,8 +6,6 @@ from typing import Iterator, Literal
from contextlib import contextmanager from contextlib import contextmanager
from collections.abc import Mapping from collections.abc import Mapping
from fastapi import HTTPException
import sangaboard import sangaboard
from labthings_fastapi.decorators import thing_action from labthings_fastapi.decorators import thing_action
from labthings_fastapi.dependencies.invocation import ( from labthings_fastapi.dependencies.invocation import (
@ -101,19 +99,6 @@ class SangaboardThing(BaseStage):
cancel, block_cancellation=block_cancellation, **displacement cancel, block_cancellation=block_cancellation, **displacement
) )
@thing_action
def abort_move(self):
"""Abort a current move"""
if self.moving:
# Skip the lock - because we need to write **before** the current query
# finishes. This merits further careful thought for thread safety.
# TODO: more robust aborts
logging.warning("Aborting move: this is an experimental feature!")
tc = self._sangaboard.termination_character
self._sangaboard._ser.write(("stop" + tc).encode())
else:
raise HTTPException(status_code=409, detail="Stage is not moving.")
@thing_action @thing_action
def set_zero_position(self): def set_zero_position(self):
"""Make the current position zero in all axes """Make the current position zero in all axes