rahix/openflexure-microscope-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add ruff checking for unnecessary comprehensions

Browse source
This commit is contained in:
Julian Stirling 2025-06-10 15:09:18 +01:00
parent 2050c2dc7c
commit 1c54d25212
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pyproject.toml
View file

@ -102,7 +102,7 @@ select = [
# "PL", # Pylint (a subset of, catches far less than pylint does) # "PL", # Pylint (a subset of, catches far less than pylint does)
# "B", # Flake8 bugbear # "B", # Flake8 bugbear
"A", # Flake8 builtins checker "A", # Flake8 builtins checker
# "C", # Flake8 comprehensions "C", # Flake8 comprehensions
# "FIX", #TODO/FIXME's in code. These should be added during develoment for ongoing tasks. # "FIX", #TODO/FIXME's in code. These should be added during develoment for ongoing tasks.
# If they are not fixed before merge they should be converted to GitLab issues # If they are not fixed before merge they should be converted to GitLab issues
# "LOG", # Flake8 logging issues (pedantic logger formatting issues can be added with "G") # "LOG", # Flake8 logging issues (pedantic logger formatting issues can be added with "G")

2
src/openflexure_microscope_server/things/camera_stage_mapping.py
View file

@ -87,7 +87,7 @@ def make_hardware_interface(
axes = stage.axis_names axes = stage.axis_names
def pos2dict(pos: Sequence[float]) -> Mapping[str, float]: def pos2dict(pos: Sequence[float]) -> Mapping[str, float]:
return {k: p for k, p in zip(axes, pos)} return dict(zip(axes, pos))
def dict2pos(posd: Mapping[str, float]) -> Sequence[float]: def dict2pos(posd: Mapping[str, float]) -> Sequence[float]:
return tuple(posd[k] for k in axes if k in posd) return tuple(posd[k] for k in axes if k in posd)

2
src/openflexure_microscope_server/things/stage/__init__.py
View file

@ -80,7 +80,7 @@ class BaseStage(Thing):
position = PropertyDescriptor( position = PropertyDescriptor(
Mapping[str, int], Mapping[str, int],
{k: 0 for k in _axis_names}, dict.fromkeys(_axis_names, 0),
description="Current position of the stage", description="Current position of the stage",
readonly=True, readonly=True,
observable=True, observable=True,

2
src/openflexure_microscope_server/things/stage/dummy.py
View file

@ -91,5 +91,5 @@ class DummyStage(BaseStage):
It is intended for use after manually or automatically recentring the It is intended for use after manually or automatically recentring the
stage. stage.
""" """
self.position = {k: 0 for k in self.axis_names} self.position = dict.fromkeys(self.axis_names, 0)
self.instantaneous_position = self.position self.instantaneous_position = self.position