From 03481f24352f333c30439fb740009c2f0559ed17 Mon Sep 17 00:00:00 2001
From: Julian Stirling <julian@julianstirling.co.uk>
Date: Fri, 7 Nov 2025 17:18:01 +0000
Subject: [PATCH] Add way to poll invoked action

---
 .../controlComponents/positionControl.vue     | 56 +++++++------------
 webapp/src/mixins/labThingsMixins.js          | 28 ++++++++++
 2 files changed, 49 insertions(+), 35 deletions(-)

diff --git a/webapp/src/components/tabContentComponents/controlComponents/positionControl.vue b/webapp/src/components/tabContentComponents/controlComponents/positionControl.vue
index fc4d4bc3..6fc3edec 100644
--- a/webapp/src/components/tabContentComponents/controlComponents/positionControl.vue
+++ b/webapp/src/components/tabContentComponents/controlComponents/positionControl.vue
@@ -25,11 +25,7 @@
               :submit-label="'Move'"
               :can-terminate="true"
               :poll-interval="0.05"
-              @taskStarted="moveLock = true"
-              @finished="
-                updatePosition();
-                moveLock = false;
-              "
+              @finished="moveComplete"
               @error="modalError"
             />
           </p>
@@ -48,7 +44,6 @@
 </template>
 
 <script>
-import axios from "axios";
 import ActionButton from "../../labThingsComponents/actionButton.vue";
 import syncPropertyButton from "../../labThingsComponents/syncPropertyButton.vue";
 
@@ -68,14 +63,8 @@ export default {
   },
 
   computed: {
-    baseUri: function () {
-      return this.$store.getters.baseUri;
-    },
     positionStatusUri: function () {
-      return `${this.baseUri}/stage/position`;
-    },
-    moveInImageCoordinatesUri: function () {
-      return this.thingActionUrl("camera_stage_mapping", "move_in_image_coordinates");
+      return this.thingActionUrl("stage", "position");
     },
   },
 
@@ -132,35 +121,32 @@ export default {
       await this.startMoveTask();
     },
     async startMoveTask() {
+      this.moveLock = true;
       await this.$refs.moveButton.startTask();
     },
-    moveInImageCoordinatesRequest: function (x, y) {
+    moveComplete() {
+      this.updatePosition();
+      this.moveLock = false;
+    },
+    async moveInImageCoordinatesRequest(x, y) {
       // If not movement-locked
       if (!this.moveLock) {
         // Lock move requests
         this.moveLock = true;
-
-        if (!this.moveInImageCoordinatesUri) {
-          this.modalError(
-            "Moving in image coordinates is not supported - you will need to upgrade your microscope's software.",
-          );
-        }
-
-        // Send move request
-        axios
-          .post(this.moveInImageCoordinatesUri, {
-            x: x, // NB the coordinates are numpy/PIL style, meaning X and Y are swapped.
+        const response = await this.invokeAction(
+          "camera_stage_mapping",
+          "move_in_image_coordinates",
+          {
+            x: x,
             y: y,
-          })
-          .then(() => {
-            this.updatePosition(); // Update the position in text boxes
-          })
-          .catch((error) => {
-            this.modalError(error); // Let mixin handle error
-          })
-          .then(() => {
-            this.moveLock = false; // Release the move lock
-          });
+          },
+        );
+        this.pollUntilComplete(
+          response.data.href,
+          null, // Nothing to do while ongoing
+          this.moveComplete, // Call move complete once done.
+          200,
+        );
       }
     },
 
diff --git a/webapp/src/mixins/labThingsMixins.js b/webapp/src/mixins/labThingsMixins.js
index 30e54a14..b6ae7aa4 100644
--- a/webapp/src/mixins/labThingsMixins.js
+++ b/webapp/src/mixins/labThingsMixins.js
@@ -9,6 +9,12 @@
 import axios from "axios";
 
 export default {
+  data() {
+    return {
+      pollTimers: {},
+    };
+  },
+
   methods: {
     thingDescription(thing) {
       return this.$store.getters["wot/thingDescription"](thing);
@@ -68,6 +74,28 @@ export default {
         return undefined;
       }
     },
+    async pollUntilComplete(taskUrl, ongoingMethod, finalMethod, interval = 500) {
+      try {
+        const response = await axios.get(taskUrl, { baseURL: this.$store.getters.baseUri });
+        const result = response.data.status;
+
+        if ((result == "running") | (result == "pending")) {
+          ongoingMethod?.(response);
+          this.pollTimers[taskUrl] = setTimeout(() => {
+            this.pollUntilComplete(taskUrl, ongoingMethod, finalMethod, interval);
+          }, interval);
+        } else {
+          clearTimeout(this.pollTimers[taskUrl]);
+          delete this.pollTimers[taskUrl];
+          finalMethod?.(response);
+        }
+      } catch (error) {
+        clearTimeout(this.pollTimers[taskUrl]);
+        delete this.pollTimers[taskUrl];
+        this.modalError(error);
+      }
+    },
+
     thingActionUrl(thing, action, allowUndefined = false) {
       let url = this.$store.getters["wot/thingActionUrl"](
         thing,