Minor code cleanup in page attributes box

This commit is contained in:
Anna Dabrowska 2026-02-17 12:03:58 +01:00
parent 434e76cf75
commit 3b38f6c6bf

View file

@ -1,5 +1,6 @@
<?php <?php
if(!defined('DOKU_INC')) die();
if (!defined('DOKU_INC')) die();
/** @var \helper_plugin_do $doPlugin */ /** @var \helper_plugin_do $doPlugin */
$doPlugin = plugin_load('helper', 'do'); $doPlugin = plugin_load('helper', 'do');
@ -12,29 +13,28 @@ $quickSubPlugin = plugin_load('helper', 'quicksubscribe');
/** @var \helper_plugin_approve_tpl $approvePlugin */ /** @var \helper_plugin_approve_tpl $approvePlugin */
$approvePlugin = plugin_load('helper', 'approve_tpl'); $approvePlugin = plugin_load('helper', 'approve_tpl');
if ($doPlugin !== null || $qcPlugin !== null || $starredPlugin !== null || $quickSubPlugin !== null || $approvePlugin !== null) { $items = [];
echo '<ul class="page-attributes">';
}
if ($qcPlugin && $qcPlugin->shouldShow()) { if ($qcPlugin && $qcPlugin->shouldShow()) {
$qcPrefix = tpl_getLang('quality_trigger'); $qcPrefix = tpl_getLang('quality_trigger');
echo '<li class="plugin_qc"><strong class="sr-out">'.$qcPrefix.':</strong><a href="#"></a></li>'; // filled by javascript // filled by javascript
$items[] = '<li class="plugin_qc"><strong class="sr-out">' . hsc($qcPrefix) . ':</strong><a href="#"></a></li>';
} }
if ($doPlugin !== null) { if ($doPlugin !== null) {
$count = $doPlugin->getPageTaskCount(); $count = $doPlugin->getPageTaskCount();
$num = $count['count']; $num = (int) $count['count'];
$title = ""; $title = '';
if($num == 0) { // no tasks - does not exist do in plug-in if ($num == 0) { // no tasks - does not exist do in plug-in
$class = "do_none"; $class = 'do_none';
$title = tpl_getLang('tasks_page_none'); $title = tpl_getLang('tasks_page_none');
} elseif($count['undone'] == 0) { // all tasks done } elseif ($count['undone'] == 0) { // all tasks done
$class = 'do_done'; $class = 'do_done';
$title = $doPlugin->getLang('title_alldone'); $title = $doPlugin->getLang('title_alldone');
} elseif($count['late'] == 0) { // open tasks but none late } elseif ($count['late'] == 0) { // open tasks but none late
$class = 'do_undone'; $class = 'do_undone';
$title = sprintf(tpl_getLang('tasks_page_intime'), $count['undone']); $title = sprintf(tpl_getLang('tasks_page_intime'), $count['undone']);
} else { // late tasks } else { // late tasks
@ -42,36 +42,32 @@ if ($doPlugin !== null) {
$title = sprintf(tpl_getLang('tasks_page_late'), $count['undone'], $count['late']); $title = sprintf(tpl_getLang('tasks_page_late'), $count['undone'], $count['late']);
} }
echo '<li class="plugin_do_pagetasks">'; $items[] = '<li class="plugin_do_pagetasks">' .
echo '<span title="'.$title.'" class="'.$class.'">'; '<span title="' . hsc($title) . '" class="' . $class . '">' .
echo inlineSVG(DOKU_PLUGIN . 'do/pix/clipboard-text.svg'); inlineSVG(DOKU_PLUGIN . 'do/pix/clipboard-text.svg') .
echo '</span>'; '</span>' .
echo '<span class="num">' . $count['undone'] . '</span>'; '<span class="num">' . (int) $count['undone'] . '</span>' .
echo '</li>'; '</li>';
} }
if ($starredPlugin !== null) { if ($starredPlugin !== null) {
echo '<li class="plugin_starred">'; $items[] = '<li class="plugin_starred">' . $starredPlugin->tpl_starred(false, false) . '</li>';
$starredPlugin->tpl_starred();
echo '</li>';
} }
if ($quickSubPlugin !== null) { if ($quickSubPlugin !== null) {
echo '<li class="plugin_quicksubscribe">'; $items[] = '<li class="plugin_quicksubscribe">' . $quickSubPlugin->tpl_subscribe() . '</li>';
echo $quickSubPlugin->tpl_subscribe();
echo '</li>';
} }
if ($approvePlugin !== null && $approvePlugin->shouldDisplay()) { if ($approvePlugin !== null && $approvePlugin->shouldDisplay()) {
echo '<li class="plugin_approve">';
echo '<span class="plugin_approve-icon">' . inlineSVG(DOKU_PLUGIN . 'approve/admin.svg') . '</span>';
echo '<div class="plugin_approve-banner-content">';
global $ACT; global $ACT;
echo $approvePlugin->banner($ACT); $items[] = '<li class="plugin_approve">' .
echo '</div>'; '<span class="plugin_approve-icon">' . inlineSVG(DOKU_PLUGIN . 'approve/admin.svg') . '</span>' .
echo '</li>'; '<div class="plugin_approve-banner-content">' .
$approvePlugin->banner($ACT) .
'</div>' .
'</li>';
} }
if ($doPlugin !== null || $qcPlugin !== null || $starredPlugin !== null || $quickSubPlugin !== null || $approvePlugin !== null) { if (!empty($items)) {
echo "</ul>"; echo '<ul class="page-attributes">' . implode('', $items) . '</ul>';
} }